[GitHub] carbondata pull request #2403: [CARBONDATA-2632][BloomDataMap] Fix bugs in b...

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2403#discussion_r199379374
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/DirectDictionaryFieldConverterImpl.java ---
    @@ -65,16 +65,22 @@ public DirectDictionaryFieldConverterImpl(DataField dataField, String nullFormat
       @Override
       public void convert(CarbonRow row, BadRecordLogHolder logHolder) {
         String value = row.getString(index);
    -    if (value == null) {
    +    row.update(convert(value, logHolder), index);
    +  }
    +
    +  @Override public Object convert(Object value, BadRecordLogHolder logHolder)
    +      throws RuntimeException {
    +    String literalValue = (String) value;
    +    if (literalValue == null) {
           logHolder.setReason(
               CarbonDataProcessorUtil.prepareFailureReason(column.getColName(), column.getDataType()));
    -      row.update(1, index);
    -    } else if (value.equals(nullFormat)) {
    -      row.update(1, index);
    +      return 1;
    --- End diff --
   
    OK~


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2403#discussion_r199379934
 
    --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomDataMapWriter.java ---
    @@ -69,6 +86,27 @@
         indexBloomFilters = new ArrayList<>(indexColumns.size());
         initDataMapFile();
         resetBloomFilters();
    +
    +    keyGenerator = segmentProperties.getDimensionKeyGenerator();
    --- End diff --
   
    Here we use the keyGenerator, ColumnarSpitter and dimensions for this segment.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6696/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5523/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5551/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2403
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2403


---