Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2406#discussion_r200239066
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/filesystem/S3CarbonFile.java ---
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *
http://www.apache.org/licenses/LICENSE-2.0 + *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.carbondata.core.datastore.filesystem;
+
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.carbondata.common.logging.LogService;
+import org.apache.carbondata.common.logging.LogServiceFactory;
+import org.apache.carbondata.core.constants.CarbonCommonConstants;
+import org.apache.carbondata.core.datastore.impl.FileFactory;
+import org.apache.carbondata.core.util.CarbonUtil;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FSDataOutputStream;
+import org.apache.hadoop.fs.FileStatus;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.LocatedFileStatus;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.fs.RemoteIterator;
+
+public class S3CarbonFile extends HDFSCarbonFile {
+
+ private static final LogService LOGGER =
+ LogServiceFactory.getLogService(HDFSCarbonFile.class.getName());
+
+ public S3CarbonFile(String filePath) {
+ super(filePath);
+ }
+
+ public S3CarbonFile(String filePath, Configuration hadoopConf) {
+ super(filePath, hadoopConf);
+ }
+
+ public S3CarbonFile(Path path) {
+ super(path);
+ }
+
+ public S3CarbonFile(Path path, Configuration hadoopConf) {
+ super(path, hadoopConf);
+ }
+
+ public S3CarbonFile(FileStatus fileStatus) {
+ super(fileStatus);
+ }
+
+ /**
+ TODO: The current implementation of renameForce is not correct as it deletes the destination
+ object and then performs rename(copy).
+ If the copy fails then there is not way to recover the old file.
+ This can happen when tablestatus.write is renamed to tablestatus.
+ One solution can be to read the content and rewrite the file as write with the same name
+ will overwrite the file by default. Need to discuss.
+ Refer CARBONDATA-2670 for tracking this.
+ */
+ @Override
+ public boolean renameForce(String changetoName) {
+ FileSystem fs;
+ try {
+ deleteFile(changetoName, FileFactory.getFileType(changetoName));
+ fs = fileStatus.getPath().getFileSystem(hadoopConf);
+ return fs.rename(fileStatus.getPath(), new Path(changetoName));
+ } catch (IOException e) {
+ LOGGER.error("Exception occured: " + e.getMessage());
+ return false;
+ }
+ }
+
+ @Override
+ public DataOutputStream getDataOutputStreamUsingAppend(String path, FileFactory.FileType fileType)
+ throws IOException {
+ return getDataOutputStream(path, fileType, CarbonCommonConstants.BYTEBUFFER_SIZE, true);
+ }
+
+ @Override public DataOutputStream getDataOutputStream(String path, FileFactory.FileType fileType,
+ int bufferSize, boolean append) throws IOException {
+ Path pt = new Path(path);
+ FileSystem fileSystem = pt.getFileSystem(FileFactory.getConfiguration());
+ FSDataOutputStream stream;
+ if (append) {
+ // append to a file only if file already exists else file not found
+ // exception will be thrown by hdfs
+ if (CarbonUtil.isFileExists(path)) {
+ DataInputStream dataInputStream = fileSystem.open(pt);
+ int count = dataInputStream.available();
+ // create buffer
+ byte[] byteStreamBuffer = new byte[count];
+ int bytesRead = dataInputStream.read(byteStreamBuffer);
+ stream = fileSystem.create(pt, true, bufferSize);
+ stream.write(byteStreamBuffer, 0, bytesRead);
+ } else {
+ stream = fileSystem.create(pt, true, bufferSize);
+ }
+ } else {
+ stream = fileSystem.create(pt, true, bufferSize);
+ }
+ return stream;
+ }
+
+ @Override
+ public CarbonFile getParentFile() {
+ Path parent = fileStatus.getPath().getParent();
+ return null == parent ? null : new S3CarbonFile(parent, hadoopConf);
+ }
+
+ @Override
+ protected CarbonFile[] getFiles(FileStatus[] listStatus) {
+ if (listStatus == null) {
+ return new CarbonFile[0];
+ }
+ CarbonFile[] files = new CarbonFile[listStatus.length];
+ for (int i = 0; i < files.length; i++) {
+ files[i] = new S3CarbonFile(listStatus[i]);
+ }
+ return files;
+ }
+
+ @Override
+ protected List<CarbonFile> getFiles(RemoteIterator<LocatedFileStatus> listStatus)
+ throws IOException {
+ List<CarbonFile> carbonFiles = new ArrayList<>();
+ while (listStatus.hasNext()) {
+ Path filePath = listStatus.next().getPath();
+ carbonFiles.add(new S3CarbonFile(filePath));
--- End diff --
CreateFile add overidden method so that, need not copy logic
---
Locked
