[GitHub] carbondata pull request #2408: [CARBONDATA-2632][BloomDataMap] Fix bugs in i...

[qiuchenjian-2]

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2408

    [CARBONDATA-2632][BloomDataMap] Fix bugs in incorrect blocklet number in bloomfilter

    The last bloomfilter index file has already been written onBlockletEnd,
    no need to write again, otherwise an extra blocklet number will be
    generated in the bloom index file.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     `NO`
     - [x] Any backward compatibility impacted?
      `NO`
     - [x] Document update required?
     `NO`
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
    `NO`
            - How it is tested? Please attach test report.
    `Tested in local machine`
            - Is it a performance related change? Please attach the performance test report.
    `NO`
            - Any additional information to help reviewers in testing this change.
           `NA`
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    `NA`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0625_bloom_dm_incorrect_number

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2408.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2408
   
----
commit 8d142f0a0b766cabac53543cc57045d49f7472a1
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-06-25T09:18:49Z

    Fix bugs in incorrect blocklet number in bloomfilter
   
    The last bloomfilter index file has already been written onBlockletEnd,
    no need to write again, otherwise an extra blocklet number will be
    generated in the bloom index file.

----


---

[qiuchenjian-2]

Github user xuchuanyin closed the pull request at:

    https://github.com/apache/carbondata/pull/2408


---

[qiuchenjian-2]

GitHub user xuchuanyin reopened a pull request:

    https://github.com/apache/carbondata/pull/2408

    [CARBONDATA-2653][BloomDataMap] Fix bugs in incorrect blocklet number in bloomfilter

    The last bloomfilter index file has already been written onBlockletEnd,
    no need to write again, otherwise an extra blocklet number will be
    generated in the bloom index file.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     `NO`
     - [x] Any backward compatibility impacted?
      `NO`
     - [x] Document update required?
     `NO`
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
    `NO`
            - How it is tested? Please attach test report.
    `Tested in local machine`
            - Is it a performance related change? Please attach the performance test report.
    `NO`
            - Any additional information to help reviewers in testing this change.
           `NA`
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    `NA`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0625_bloom_dm_incorrect_number

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2408.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2408
   
----
commit 8d142f0a0b766cabac53543cc57045d49f7472a1
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-06-25T09:18:49Z

    Fix bugs in incorrect blocklet number in bloomfilter
   
    The last bloomfilter index file has already been written onBlockletEnd,
    no need to write again, otherwise an extra blocklet number will be
    generated in the bloom index file.

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2408
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6522/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2408
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5354/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2408
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6531/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2408
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5362/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2408
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6540/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2408
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5444/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2408
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5369/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2408#discussion_r199044379
 
    --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomDataMapWriter.java ---
    @@ -197,7 +199,7 @@ protected void writeBloomDataMapFile() {
       @Override
       public void finish() throws IOException {
         if (!isWritingFinished()) {
    -      if (indexBloomFilters.size() > 0) {
    +      if (isWriteFromBuilder && indexBloomFilters.size() > 0) {
    --- End diff --
   
    I think override `finish` method in `BloomDataMapBuilder.java` is better than adding a member variable here


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2408
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5530/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2408
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6675/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2408
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5502/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2408
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2408
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6687/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2408
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2408


---