[GitHub] carbondata pull request #2414: [CARBONDATA-2658][DataLoad]No difference in m...

[qiuchenjian-2]

GitHub user ndwangsen opened a pull request:

    https://github.com/apache/carbondata/pull/2414

    [CARBONDATA-2658][DataLoad]No difference in memory spilled to disk for any value of carbon.load.sortMemory.spill.percentage

    the parameter carbon.load.sortMemory.spill.percentage configured the value range 0-100,according to configuration merge and spill in-memory pages to disk
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     NA
     - [ ] Any backward compatibility impacted?
     NA
     - [ ] Document update required?
    NA
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           Test pass in environment
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ndwangsen/incubator-carbondata bugfix_09939

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2414.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2414
   
----
commit 736c571ce911374d8cde16f9d6f64b310984f5e9
Author: ndwangsen <luffy.wang@...>
Date:   2018-06-22T04:02:36Z

    ADD carbon.load.sortMemory.spill.percentage parameter  invalid value
    check

commit 1671f3b114d229c81c4ea7b8023d80334e512df0
Author: ndwangsen <luffy.wang@...>
Date:   2018-06-25T06:24:56Z

    Update CarbonLoadOptionConstants.java
   
    add a space

commit a976783f6787ec1401389a3427820aa1b572a5dc
Author: ndwangsen <luffy.wang@...>
Date:   2018-06-26T12:19:22Z

    the parameter carbon.load.sortMemory.spill.percentage configured the
    value range 0-100,according to configuration merge and spill in-memory
    pages to disk

----


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2414
 
    Better to change the title to 'Fix bugs in spilling in-memory pages'
   
    Besides, Is there any PR that this PR depends on?


---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2414
 
    Is this pr base on PR-2397?


---

[qiuchenjian-2]

Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2414#discussion_r198162947
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/merger/UnsafeIntermediateMerger.java ---
    @@ -88,13 +88,25 @@ public UnsafeIntermediateMerger(SortParameters parameters) {
               CarbonLoadOptionConstants.CARBON_LOAD_SORT_MEMORY_SPILL_PERCENTAGE,
               CarbonLoadOptionConstants.CARBON_LOAD_SORT_MEMORY_SPILL_PERCENTAGE_DEFAULT);
           spillPercentage = Integer.valueOf(spillPercentageStr);
    +      if (spillPercentage > 100 || spillPercentage < 0) {
    --- End diff --
   
    One suggestion: add a function, called 'getSortMemorySpillPercentage', in 'CarbonProperties' to get the value of 'CARBON_LOAD_SORT_MEMORY_SPILL_PERCENTAGE', and validate the value in this function. We don't need to validate this value again if other place need to use this config, just need to call 'getSortMemorySpillPercentage'.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2414
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5388/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2414
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6562/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2414
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5469/



---

[qiuchenjian-2]

Github user ndwangsen commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2414#discussion_r199112802
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/merger/UnsafeIntermediateMerger.java ---
    @@ -88,13 +88,25 @@ public UnsafeIntermediateMerger(SortParameters parameters) {
               CarbonLoadOptionConstants.CARBON_LOAD_SORT_MEMORY_SPILL_PERCENTAGE,
               CarbonLoadOptionConstants.CARBON_LOAD_SORT_MEMORY_SPILL_PERCENTAGE_DEFAULT);
           spillPercentage = Integer.valueOf(spillPercentageStr);
    +      if (spillPercentage > 100 || spillPercentage < 0) {
    --- End diff --
   
    yes this pr base on #2397


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2414
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6655/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2414
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5482/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2414
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2414
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6754/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2414
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5586/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2414
 
    LGTM


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2414
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6803/



---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2414
 
    retest this please



---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2414
 
    retest sdv please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2414
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6868/



---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2414
 
    retest sdv please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2414
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5663/



---