[GitHub] carbondata pull request #2420: [WIP] updated rename command so that table di...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2420
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5599/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2420
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6777/



---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2420
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2420
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5619/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2420
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6790/



---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2420#discussion_r200234399
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/BadRecordsLoggerProvider.java ---
    @@ -92,13 +90,7 @@ public static String getBadLogStoreLocation(CarbonDataLoadConfiguration configur
           String storeLocation) {
         String badLogStoreLocation = (String) configuration
             .getDataLoadProperty(CarbonLoadOptionConstants.CARBON_OPTIONS_BAD_RECORD_PATH);
    -    if (null == badLogStoreLocation) {
    -      badLogStoreLocation =
    -          CarbonProperties.getInstance().getProperty(CarbonCommonConstants.CARBON_BADRECORDS_LOC);
    -    }
    -    badLogStoreLocation = badLogStoreLocation + File.separator + storeLocation;
    -
    -    return badLogStoreLocation;
    +    return badLogStoreLocation + File.separator + storeLocation;
    --- End diff --
   
    CarbontablePath has path building functions, move all path building there


---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2420#discussion_r200237355
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/executor/util/QueryUtil.java ---
    @@ -378,8 +377,14 @@ private static void getChildDimensionDictionaryDetail(CarbonDimension queryDimen
             ColumnIdentifier columnIdentifier;
             if (null != dimension.getColumnSchema().getParentColumnTableRelations() && !dimension
                 .getColumnSchema().getParentColumnTableRelations().isEmpty()) {
    -          dictionarySourceAbsoluteTableIdentifier = getTableIdentifierForColumn(dimension,
    -              carbonTable.getAbsoluteTableIdentifier());
    +          RelationIdentifier parentRelationIdentifier =
    --- End diff --
   
    separate to function


---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2420#discussion_r200234454
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonHiveMetaStore.scala ---
    @@ -158,13 +158,11 @@ class CarbonHiveMetaStore extends CarbonFileMetastore {
           oldTablePath: String,
           sparkSession: SparkSession,
           schemaConverter: ThriftWrapperSchemaConverterImpl) = {
    -    val newTablePath =
    -      CarbonTablePath.getNewTablePath(oldTablePath, newTableIdentifier.getTableName)
         val wrapperTableInfo = schemaConverter.fromExternalToWrapperTableInfo(
           thriftTableInfo,
           newTableIdentifier.getDatabaseName,
           newTableIdentifier.getTableName,
    -      newTablePath)
    +      oldTablePath)
    --- End diff --
   
    rename to tablePath


---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2420#discussion_r200234535
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/AlterTableUtil.scala ---
    @@ -107,19 +107,10 @@ object AlterTableUtil {
        *
        * @param locks
        * @param locksAcquired
    -   * @param dbName
    -   * @param tableName
    -   * @param tablePath
        */
    -  def releaseLocksManually(locks: List[ICarbonLock],
    -      locksAcquired: List[String],
    -      dbName: String,
    -      tableName: String,
    -      tablePath: String): Unit = {
    -    val lockLocation = tablePath
    +  def releaseLocksManually(locks: List[ICarbonLock], locksAcquired: List[String]): Unit = {
         locks.zip(locksAcquired).foreach { case (carbonLock, lockType) =>
    -      val lockFilePath = CarbonTablePath.getLockFilePath(lockLocation, lockType)
    -      if (carbonLock.releaseLockManually(lockFilePath)) {
    +      if (carbonLock.unlock()) {
    --- End diff --
   
    locks can be removed as state updation is only in hive


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2420
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5608/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2420
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6802/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2420
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6812/



---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2420
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2420
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6816/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2420
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5618/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2420
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6822/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2420
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5630/



---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2420
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2420
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6839/



---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2420
 
    retest this please


---