[GitHub] carbondata pull request #2452: [CARBONDATA-2693][BloomDataMap]Fix bug for al...

[qiuchenjian-2]

GitHub user ndwangsen opened a pull request:

    https://github.com/apache/carbondata/pull/2452

    [CARBONDATA-2693][BloomDataMap]Fix bug for alter rename is renameing the existing table on which bloomfilter datamp exists

    Fix bug for alter rename is renameing the existing table on which bloomfilter datamp exists
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     NA
     - [ ] Any backward compatibility impacted?
     NA
     - [ ] Document update required?
    NA
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
          add a test case ,test pass in environment
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ndwangsen/incubator-carbondata bugfix_rename_dm_table

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2452.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2452
   
----
commit d96c8ed235cab72c2ab65384473ccf2dce65444e
Author: ndwangsen <luffy.wang@...>
Date:   2018-07-05T08:51:39Z

    [CARBONDATA-2693]Fix bug for alter rename is renameing the existing
   
    table on which bloomfilter datamp exists

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2452
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5619/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2452
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6818/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2452
 
    retest this please


---

[qiuchenjian-2]

Github user ndwangsen commented on the issue:

    https://github.com/apache/carbondata/pull/2452
 
    retest this please



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2452
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6891/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2452
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5671/



---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2452
 
    retest this please


---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2452
 
    retest sdv please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2452
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6923/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2452
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5709/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2452
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5694/



---

[qiuchenjian-2]

Github user ndwangsen commented on the issue:

    https://github.com/apache/carbondata/pull/2452
 
    retest this please



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2452
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6933/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2452
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5719/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2452#discussion_r200895365
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -2814,6 +2817,22 @@ public static boolean hasAggregationDataMap(CarbonTable carbonTable) {
         return false;
       }
     
    +  /**
    +   * Utility function to check whether table has mv datamap or not
    +   * @param carbonTable
    +   * @return timeseries data map present
    --- End diff --
   
    change to `return true if MV datamap present in the specified table`


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2452#discussion_r200895780
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java ---
    @@ -172,6 +174,48 @@ public void dropDataMapSchema(String dataMapName) throws IOException {
         provider.dropSchema(dataMapName);
       }
     
    +  /**
    +   * Update the datamap schema to storage by table rename
    --- End diff --
   
    shouldn't be `Update the datamap schema after table rename`?


---

[qiuchenjian-2]

Github user ndwangsen commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2452#discussion_r200910090
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -2814,6 +2817,22 @@ public static boolean hasAggregationDataMap(CarbonTable carbonTable) {
         return false;
       }
     
    +  /**
    +   * Utility function to check whether table has mv datamap or not
    +   * @param carbonTable
    +   * @return timeseries data map present
    --- End diff --
   
    ok , i change it


---

[qiuchenjian-2]

Github user ndwangsen commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2452#discussion_r200910555
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -2814,6 +2817,22 @@ public static boolean hasAggregationDataMap(CarbonTable carbonTable) {
         return false;
       }
     
    +  /**
    +   * Utility function to check whether table has mv datamap or not
    +   * @param carbonTable
    +   * @return timeseries data map present
    --- End diff --
   
    ok， i am modifying it


---

[qiuchenjian-2]

Github user ndwangsen commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2452#discussion_r200910733
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java ---
    @@ -172,6 +174,48 @@ public void dropDataMapSchema(String dataMapName) throws IOException {
         provider.dropSchema(dataMapName);
       }
     
    +  /**
    +   * Update the datamap schema to storage by table rename
    --- End diff --
   
    ok，i am modifying it.


---