[GitHub] carbondata pull request #2454: [WIP] [CARBONDATA-2701] Refactor code to stor...

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2454#discussion_r200965517
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java ---
    @@ -184,6 +185,23 @@ public BlockletDataMapIndexWrapper get(TableBlockIndexUniqueIdentifierWrapper id
        */
       @Override public void invalidate(
           TableBlockIndexUniqueIdentifierWrapper tableSegmentUniqueIdentifierWrapper) {
    +    BlockletDataMapIndexWrapper blockletDataMapIndexWrapper =
    +        getIfPresent(tableSegmentUniqueIdentifierWrapper);
    +    if (null != blockletDataMapIndexWrapper) {
    +      // clear the segmentProperties cache
    +      List<BlockDataMap> dataMaps = blockletDataMapIndexWrapper.getDataMaps();
    +      if (null != dataMaps) {
    +        String segmentId =
    +            tableSegmentUniqueIdentifierWrapper.getTableBlockIndexUniqueIdentifier().getSegmentId();
    +        for (BlockDataMap dataMap : dataMaps) {
    --- End diff --
   
    this for loop will run ony once , change this to dataMap.get(0)


---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2454#discussion_r200966124
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockDataMap.java ---
    @@ -16,7 +16,9 @@
      */
     package org.apache.carbondata.core.indexstore.blockletindex;
     
    -import java.io.*;
    +import java.io.IOException;
    --- End diff --
   
    Remove this change


---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2454
 
    LGTM except few minor comments
    @manishgupta88 Please check


---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2454
 
    @kumarvishal09 ..As discussed with you I have handled these comments as part of PR https://github.com/apache/carbondata/pull/2467


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2454


---