[GitHub] carbondata pull request #2480: [CARBONDATA-2550][CARBONDATA-2576][MV] Fix li...

[qiuchenjian-2]

GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/2480

    [CARBONDATA-2550][CARBONDATA-2576][MV] Fix limit and average function issue in MV query

    This PR depends on https://github.com/apache/carbondata/pull/2453
    Problem: Limit is not working on mv queries and the average is also not working.
    Solution: Correct the limit queries and average queries through making as full refresh query.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata mv-2550

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2480.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2480
   
----
commit 844cff764e94f18ff8d115ccd636a06a0931bffb
Author: ravipesala <ravi.pesala@...>
Date:   2018-06-14T06:10:07Z

    Fixed order by in mv and aggregation functions inside projection expressions are fixed

commit 5cfc99f38b13be859c49a7eca00cd139d211947d
Author: ravipesala <ravi.pesala@...>
Date:   2018-07-09T11:40:56Z

    Fix limit issue in mv

commit 4845d2bac795ab478c5b660887a05b51670cb785
Author: ravipesala <ravi.pesala@...>
Date:   2018-07-09T13:01:22Z

    Fix avg function mv issue query issue.

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2480
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5763/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2480
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6999/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2480
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5751/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2480
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7090/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2480
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7190/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2480
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5965/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2480
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5856/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2480#discussion_r202710990
 
    --- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala ---
    @@ -159,7 +159,12 @@ object MVHelper {
         logicalPlan.transformAllExpressions {
           case a: Alias =>
             a
    -      case agg: AggregateExpression => agg
    +      case agg: AggregateExpression =>
    +        isFullReload = agg.aggregateFunction match {
    +          case avg: Average => true
    --- End diff --
   
    Can you add comment to explain why it is true


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2480#discussion_r202711165
 
    --- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala ---
    @@ -385,7 +390,7 @@ object MVHelper {
                 val relation =
                   g.dataMapTableRelation.get.asInstanceOf[MVPlanWrapper].plan.asInstanceOf[Select]
                 val aliasMap = getAttributeMap(relation.outputList, g.outputList)
    -            val updatedFlagSpec: Seq[Seq[ArrayBuffer[SortOrder]]] = updateSortOrder(
    +            val updatedFlagSpec: Seq[Seq[Any]] = updateSortOrder(
    --- End diff --
   
    Is this for limit to work? can you add comment


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2480#discussion_r202897345
 
    --- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala ---
    @@ -385,7 +390,7 @@ object MVHelper {
                 val relation =
                   g.dataMapTableRelation.get.asInstanceOf[MVPlanWrapper].plan.asInstanceOf[Select]
                 val aliasMap = getAttributeMap(relation.outputList, g.outputList)
    -            val updatedFlagSpec: Seq[Seq[ArrayBuffer[SortOrder]]] = updateSortOrder(
    +            val updatedFlagSpec: Seq[Seq[Any]] = updateSortOrder(
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2480#discussion_r202897352
 
    --- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala ---
    @@ -159,7 +159,12 @@ object MVHelper {
         logicalPlan.transformAllExpressions {
           case a: Alias =>
             a
    -      case agg: AggregateExpression => agg
    +      case agg: AggregateExpression =>
    +        isFullReload = agg.aggregateFunction match {
    +          case avg: Average => true
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2480
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7288/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2480
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6055/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2480
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7298/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2480
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6065/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2480
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5918/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2480#discussion_r204438372
 
    --- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala ---
    @@ -429,7 +436,7 @@ object MVHelper {
       /**
        * Updates the flagspec of given select plan with attributes of relation select plan
        */
    -  private def updateSortOrder(keepAlias: Boolean,
    +  private def updateFlagSpec(keepAlias: Boolean,
           select: Select,
           relation: Select,
           aliasMap: Map[AttributeKey, NamedExpression]) = {
    --- End diff --
   
    please add return type to this func


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2480#discussion_r204481327
 
    --- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala ---
    @@ -429,7 +436,7 @@ object MVHelper {
       /**
        * Updates the flagspec of given select plan with attributes of relation select plan
        */
    -  private def updateSortOrder(keepAlias: Boolean,
    +  private def updateFlagSpec(keepAlias: Boolean,
           select: Select,
           relation: Select,
           aliasMap: Map[AttributeKey, NamedExpression]) = {
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2480
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7417/



---