[GitHub] carbondata pull request #2486: [CARBONDATA-2723][DataMap] Fix bugs in recrea...

[qiuchenjian-2]

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2486

    [CARBONDATA-2723][DataMap] Fix bugs in recreate datamap on table

    While we drop datamap/table, the executor side cache for datamap is
    stale. So if we recreate the datamap with different index columns, when
    we are doing data loading, the cache should be cleaned, otherwise the
    DataMapWriterListener will not take effect for the new datamap.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata CARBONDATA-2723_bug_recreate_dm

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2486.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2486
   
----
commit a5a2b6f94cd42418106be2eba04d2d300a0f3891
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-07-11T04:23:18Z

    Fix bugs in recreate datamap on table
   
    While we drop datamap/table, the executor side cache for datamap is
    stale. So if we recreate the datamap with different index columns, when
    we are doing data loading, the cache should be cleaned, otherwise the
    DataMapWriterListener will not take effect for the new datamap.

----


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2486#discussion_r201593468
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java ---
    @@ -431,6 +431,7 @@ public void clearDataMaps(String tableUniqName) {
             }
           }
         }
    +    allDataMaps.remove(tableUniqName);
    --- End diff --
   
    FYI: This is the first keypoint


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2486#discussion_r201593530
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/datamap/DataMapWriterListener.java ---
    @@ -54,6 +54,9 @@
        */
       public void registerAllWriter(CarbonTable carbonTable, String segmentId,
           String taskNo, SegmentProperties segmentProperties) {
    +    // clear cache in executor side
    --- End diff --
   
    FYI: This is the second keypoint


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2486
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7016/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2486
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5793/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2486
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5768/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2486
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2486
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5785/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2486#discussion_r202007773
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapMeta.java ---
    @@ -74,6 +74,6 @@ public String getDataMapName() {
       @Override
       public String toString() {
         return "DataMapMeta{" + "dataMapName='" + dataMapName + '\'' + ", indexedColumns="
    -        + indexedColumns + ", optimizedOperation=" + optimizedOperation + '}';
    +        + getIndexedColumnNames() + ", optimizedOperation=" + optimizedOperation + '}';
    --- End diff --
   
    can you change this to use String.format


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2486#discussion_r202221875
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapMeta.java ---
    @@ -74,6 +74,6 @@ public String getDataMapName() {
       @Override
       public String toString() {
         return "DataMapMeta{" + "dataMapName='" + dataMapName + '\'' + ", indexedColumns="
    -        + indexedColumns + ", optimizedOperation=" + optimizedOperation + '}';
    +        + getIndexedColumnNames() + ", optimizedOperation=" + optimizedOperation + '}';
    --- End diff --
   
    OK, change it to stringbuilder


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2486
 
    comments are resolved


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2486
 
    retest this please


---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2486
 
    retest sdv please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2486
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7086/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2486
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5863/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2486
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5819/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2486
 
    retest sdv please


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2486
 
    The error in SDV is not related to this PR：
    ```
    org.apache.carbondata.cluster.sdv.generated.QueriesIncludeDictionaryTestCase.TABLE_DICTIONARY_INCLUDE_PushUP_044
    Results do not match for query:
    == Results ==
    !== Correct Answer - 1 ==   == Spark Answer - 1 ==
    ![7.452597748961225E39]     [7.452597748961223E39]
         
          at org.scalatest.Assertions$class.newAssertionFailedException(Assertions.scala:495)
          at org.scalatest.FunSuite.newAssertionFailedException(FunSuite.scala:1555)
          at org.scalatest.Assertions$class.fail(Assertions.scala:1328)
          at org.scalatest.FunSuite.fail(FunSuite.scala:1555)
          at org.apache.spark.sql.common.util.QueryTest.checkAnswer(QueryTest.scala:75)
          at org.apache.spark.sql.common.util.QueryTest.writeAndCheckAnswer(QueryTest.scala:113)
    ```


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2486
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2486


---