[GitHub] carbondata pull request #2487: [WIP]Fixed Complex type array GC issue

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2487#discussion_r203608929
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/SafeVarLengthColumnPage.java ---
    @@ -40,6 +40,7 @@
       @Override
       public void freeMemory() {
         byteArrayData = null;
    +    rowOffset.freeMemory();
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2487#discussion_r203608948
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java ---
    @@ -201,31 +209,32 @@ private static ColumnPage getComplexLVBytesColumnPage(TableSpec.ColumnSpec colum
           throws MemoryException {
         // extract length and data, set them to rowOffset and unsafe memory correspondingly
         int rowId = 0;
    -    List<Integer> rowOffset = new ArrayList<>();
    -    List<Integer> rowLength = new ArrayList<>();
    +    TableSpec.ColumnSpec spec = TableSpec.ColumnSpec
    +        .newInstance(columnSpec.getFieldName(), DataTypes.INT, ColumnType.MEASURE);
    +    ColumnPage rowOffset = ColumnPage.newPage(spec, DataTypes.INT, 1024);
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2487#discussion_r203608964
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java ---
    @@ -175,24 +182,25 @@ private static ColumnPage getLVBytesColumnPage(TableSpec.ColumnSpec columnSpec,
           throws MemoryException {
         // extract length and data, set them to rowOffset and unsafe memory correspondingly
         int rowId = 0;
    -    List<Integer> rowOffset = new ArrayList<>();
    -    List<Integer> rowLength = new ArrayList<>();
    +    TableSpec.ColumnSpec spec = TableSpec.ColumnSpec
    +        .newInstance(columnSpec.getFieldName(), DataTypes.INT, ColumnType.MEASURE);
    +    ColumnPage rowOffset = ColumnPage.newPage(spec, DataTypes.INT, 1024);
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user gvramana commented on the issue:

    https://github.com/apache/carbondata/pull/2487
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2487


---