[GitHub] carbondata pull request #2489: [CARBONDATA-2606][Complex DataType Enhancemen...

[qiuchenjian-2]

GitHub user Indhumathi27 opened a pull request:

    https://github.com/apache/carbondata/pull/2489

    [CARBONDATA-2606][Complex DataType Enhancements]Fix Null result if First two Projection column have same parent and third column has different Parent Struct

   
    Problem:
     When multiple columns are there,then the first child elements is only going to make parent Object Array. For all other cases it should be null.
     For e.g. a : <b,c,d>. here as 'a' is the parent column and b, c, d are child columns during traversal when we encounter the first element in list i.e. column 'b','a' will be completely filled. In case when column 'c' and 'd' encountered then only place null in the output.
    Hence, as Null is placed in the output, Select result is Null if First two Projection column have same parent and third column has different parent Struct column.
    Solution: Place null in the end of output
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [x] Testing done
           Test cases added
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Indhumathi27/carbondata project2struct

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2489.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2489
   
----
commit be3008224f100d6e046987ab4c56792976d6c3a4
Author: Indhumathi27 <indhumathim27@...>
Date:   2018-07-11T10:24:55Z

    [CARBONDATA-2606][Complex DataType Enhancements]Fix Null result when there are two Struct Column

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7024/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5804/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7037/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5775/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5812/



---

[qiuchenjian-2]

Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5783/



---

[qiuchenjian-2]

Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2489#discussion_r202076454
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java ---
    @@ -140,6 +140,13 @@ public DictionaryBasedResultCollector(BlockExecutionInfo blockExecutionInfos) {
             continue;
           }
           fillMeasureData(scannedResult, row);
    +      if (scannedResult.complexParentIndexToQueryMap.toString().contains("StructQueryType")) {
    --- End diff --
   
    put a comment explaining the logic.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7067/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5842/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5810/



---

[qiuchenjian-2]

Github user Indhumathi27 commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    Retest sdv please


---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    LGTM


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7083/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5860/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5818/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5821/



---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    LGTM


---

[qiuchenjian-2]

Github user Indhumathi27 commented on the issue:

    https://github.com/apache/carbondata/pull/2489
 
    Retest this please


---