[GitHub] carbondata pull request #2490: [CARBONDATA-2727] Support create bloom datama...

[qiuchenjian-2]

GitHub user kevinjmh opened a pull request:

    https://github.com/apache/carbondata/pull/2490

    [CARBONDATA-2727] Support create bloom datamap on newly added column

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   
   
    - Add a result collector with rowId infomation for datamap rebuild if table schema is changed;
    - Use keygenerator to retrieve surrogate value of dictIndexColumn  from query result;

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kevinjmh/carbondata bloom_new_column

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2490.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2490
   
----
commit 6ed28f07360ef88cbd5079eaf7d6b76ea69cddf1
Author: Manhua <kevinjmh@...>
Date:   2018-07-11T11:39:31Z

    support create bloom datamap on newly added column

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2490
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7028/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2490
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5803/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2490
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5779/



---

[qiuchenjian-2]

Github user kevinjmh commented on the issue:

    https://github.com/apache/carbondata/pull/2490
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2490
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7039/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2490
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5816/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2490
 
    retest sdv please


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2490
 
    please fix the comments


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2490#discussion_r202230753
 
    --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/AbstractBloomDataMapWriter.java ---
    @@ -173,7 +173,13 @@ protected void addValue2BloomIndex(int indexColIdx, Object value) {
         } else {
           if (indexColumns.get(indexColIdx).hasEncoding(Encoding.DICTIONARY)
               || indexColumns.get(indexColIdx).hasEncoding(Encoding.DIRECT_DICTIONARY)) {
    -        indexValue = convertDictionaryValue(indexColIdx, (byte[]) value);
    +        if (value.getClass().isArray()) {
    --- End diff --
   
    Maybe we can add a variable to indicate whether it is from 'Rebuild(builder0' or 'DirectWrite(writer)'. Use the class type as condition is not proper.
    Do not forget to add comments for that variable.


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2490#discussion_r202230960
 
    --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/datamap/IndexDataMapRebuildRDD.scala ---
    @@ -154,89 +160,112 @@ class OriginalReadSupport(dataTypes: Array[DataType]) extends CarbonReadSupport[
      */
     class RawBytesReadSupport(segmentProperties: SegmentProperties, indexColumns: Array[CarbonColumn])
       extends CarbonReadSupport[Array[Object]] {
    -  var columnarSplitter: ColumnarSplitter = _
    +  var dimensionKeyGenerator: KeyGenerator = _
    +  // for the dictionary dimensions
    +  var indexCol2IdxInDictArray: Map[String, Int] = Map()
       // for the non dictionary dimensions
       var indexCol2IdxInNoDictArray: Map[String, Int] = Map()
       // for the measures
       var indexCol2IdxInMeasureArray: Map[String, Int] = Map()
    -  // for the dictionary/date dimensions
    -  var dictIndexCol2MdkIndex: Map[String, Int] = Map()
    -  var mdkIndex2DictIndexCol: Map[Int, String] = Map()
    -  var existDim = false
    +
    +  /**
    +   * use same way as restructure based result collector to prepare
    +   * key generator to get surrogate value of dict column result.
    +   * Refer to `RestructureBasedRowIdRawResultCollector`
    +   */
    --- End diff --
   
    please add description to explain why this modification is needed compared with previous version. what's the scenario or intention?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2490
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7082/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2490
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5859/



---

[qiuchenjian-2]

Github user kevinjmh commented on the issue:

    https://github.com/apache/carbondata/pull/2490
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2490
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5827/



---

[qiuchenjian-2]

Github user kevinjmh commented on the issue:

    https://github.com/apache/carbondata/pull/2490
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2490
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7173/



---

[qiuchenjian-2]

Github user kevinjmh commented on the issue:

    https://github.com/apache/carbondata/pull/2490
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2490
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5845/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2490
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5949/



---