[GitHub] carbondata pull request #2494: [CARBONDATA-2734] Fix struct of date issue in...

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2494: [CARBONDATA-2734] Fix struct of date issue in...

qiuchenjian-2
GitHub user ajantha-bhat opened a pull request:

    https://github.com/apache/carbondata/pull/2494

    [CARBONDATA-2734] Fix struct of date issue in create table

    problem: Struct of date is not supported currently in create table flow
    as date datatype check is missing during parsing.
    Hence child date column was not appended with parent name, leading to
    StringOutOfIndex exception.
   
    solution: Handle the date DataType as a complex child during column
    formation.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?NA
     
     - [ ] Any backward compatibility impacted?NA
     
     - [ ] Document update required?NA
   
     - [ ] Testing done. Updated the UT.
   
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ajantha-bhat/carbondata issue_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2494.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2494
   
----
commit e8c6e49f12df5d2f4a17e1de05f8a14cf7605c94
Author: ajantha-bhat <ajanthabhat@...>
Date:   2018-07-11T11:58:45Z

    [CARBONDATA-2734] support struct of date in create table
   
    problem: Struct of date is not supported currently in create table flow
    as date datatype check is missing during parsing.
    Hence child date column was not appended with parent name, leading to
    StringOutOfIndex excpetion.
   
    solution: Handle the date DataType as a complex child during column
    formation.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2494: [CARBONDATA-2734] Fix struct of date issue in create...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2494
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7033/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2494: [CARBONDATA-2734] Fix struct of date issue in create...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2494
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5810/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2494: [CARBONDATA-2734] Fix struct of date issue in create...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2494
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7046/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2494: [CARBONDATA-2734] Fix struct of date issue in create...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2494
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5823/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2494: [CARBONDATA-2734] Fix struct of date issue in create...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2494
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5789/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2494: [CARBONDATA-2734] Fix struct of date issue in create...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2494
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5833/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2494: [CARBONDATA-2734] Fix struct of date issue in create...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2494
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7059/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2494: [CARBONDATA-2734] Fix struct of date issue in create...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2494
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5800/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2494: [CARBONDATA-2734] Fix struct of date issue in create...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/2494
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2494: [CARBONDATA-2734] Fix struct of date issue in create...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2494
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7081/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2494: [CARBONDATA-2734] Fix struct of date issue in create...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2494
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5858/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2494: [CARBONDATA-2734] Fix struct of date issue in create...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2494
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2494: [CARBONDATA-2734] Fix struct of date issue in...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2494


---