[GitHub] carbondata pull request #2496: [CARBONDATA-2737][WIP] Complex type filter as...

classic Classic list List threaded Threaded
24 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2496: [CARBONDATA-2737][WIP] Complex type filter as...

qiuchenjian-2
GitHub user gvramana opened a pull request:

    https://github.com/apache/carbondata/pull/2496

    [CARBONDATA-2737][WIP] Complex type filter as projection push down

    select a.c from table1 where a.b = 10;
    select a.c from table1 order by a.b;
   
    These cases a.b needs to be pushed down to carbon as "a.b" instead of fetching complete "a".
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed? No
     
     - [ ] Any backward compatibility impacted? No
     
     - [ ] Document update required? No
   
     - [ ] Testing done -Yes
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gvramana/topcarbondata complex_filter_as_projection

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2496.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2496
   
----
commit c5f5d3afc11152e7b0ec7cf24c207c0678063731
Author: Venkata Ramana G <ramana.gollamudi@...>
Date:   2018-07-12T05:29:43Z

    complextype filter as projection pushdown

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2496: [CARBONDATA-2737][WIP] Complex type filter as projec...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2496
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7047/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2496: [CARBONDATA-2737][WIP] Complex type filter as projec...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2496
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5824/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2496: [CARBONDATA-2737][WIP] Complex type filter as projec...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2496
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5790/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2496: [CARBONDATA-2737][WIP] Complex type filter as projec...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2496
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7058/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2496: [CARBONDATA-2737][WIP] Complex type filter as projec...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2496
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5837/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2496: [CARBONDATA-2737][WIP] Complex type filter as projec...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2496
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5802/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2496: [CARBONDATA-2737][WIP] Complex type filter as projec...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2496
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7080/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2496: [CARBONDATA-2737][WIP] Complex type filter as projec...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2496
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5857/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2496: [CARBONDATA-2737][WIP] Complex type filter as...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2496#discussion_r202911491
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonComplexTypeRule.scala ---
    @@ -0,0 +1,96 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.optimizer
    +
    +import scala.collection.mutable
    +
    +import org.apache.spark.sql.CarbonDatasourceHadoopRelation
    +import org.apache.spark.sql.catalyst.expressions.{
    +  Alias, Attribute, AttributeReference,
    +  Expression, GetStructField, NamedExpression, PredicateHelper
    +}
    +import org.apache.spark.sql.catalyst.plans.logical.{LogicalPlan, Project}
    +import org.apache.spark.sql.catalyst.rules.Rule
    +import org.apache.spark.sql.execution.datasources.LogicalRelation
    +
    +/**
    + * Push down complex type attribute reference to CarbonDataRelation
    + */
    +class CarbonComplexTypeRule extends Rule[LogicalPlan] with PredicateHelper {
    --- End diff --
   
    Where did you add this rule? It is not yet wired?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2496: [CARBONDATA-2737][WIP] Complex type filter as...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2496#discussion_r202911646
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestComplexDataType.scala ---
    @@ -667,4 +667,15 @@ class TestComplexDataType extends QueryTest with BeforeAndAfterAll {
         checkAnswer(sql("select a.b from test where id=3 or a.c=3"),Seq(Row(5),Row(2)))
       }
     
    +  test("test Filter as projection PushDown for more than one Struct column Cases -1") {
    +    sql("drop table if exists test")
    +    sql("create table test (a struct<b:int, c:struct<d:int,e:int>>) stored by 'carbondata'")
    +    sql("insert into test select '1$2:3'")
    +    checkAnswer(sql("select * from test"), Seq(Row(Row(1, Row(2, 3)))))
    +    checkAnswer(sql("select a.b, a.c from test where a.c.e = 3"), Seq(Row(1, Row(2, 3))))
    +    checkAnswer(sql("select a.c.e from test where a.c.e = 3"), Seq(Row(3)))
    +    checkAnswer(sql("select a.c.d from test where a.c.e = 3"), Seq(Row(2)))
    --- End diff --
   
    Verify the plan whether push down is happening or not


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2496: [CARBONDATA-2737][Complex DataType Enhancemen...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2496#discussion_r202971224
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonComplexTypeRule.scala ---
    @@ -0,0 +1,96 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.optimizer
    +
    +import scala.collection.mutable
    +
    +import org.apache.spark.sql.CarbonDatasourceHadoopRelation
    +import org.apache.spark.sql.catalyst.expressions.{
    +  Alias, Attribute, AttributeReference,
    +  Expression, GetStructField, NamedExpression, PredicateHelper
    +}
    +import org.apache.spark.sql.catalyst.plans.logical.{LogicalPlan, Project}
    +import org.apache.spark.sql.catalyst.rules.Rule
    +import org.apache.spark.sql.execution.datasources.LogicalRelation
    +
    +/**
    + * Push down complex type attribute reference to CarbonDataRelation
    + */
    +class CarbonComplexTypeRule extends Rule[LogicalPlan] with PredicateHelper {
    --- End diff --
   
    Previously it was not complete, now you can check.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2496: [CARBONDATA-2737][Complex DataType Enhancements] Com...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2496
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7254/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2496: [CARBONDATA-2737][Complex DataType Enhancements] Com...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2496
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6030/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2496: [CARBONDATA-2737][Complex DataType Enhancements] Com...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2496
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7264/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2496: [CARBONDATA-2737][Complex DataType Enhancements] Com...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2496
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/40/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2496: [CARBONDATA-2737][Complex DataType Enhancements] Com...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2496
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8530/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2496: [CARBONDATA-2737][Complex DataType Enhancements] Com...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2496
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/460/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2496: [CARBONDATA-2737][Complex DataType Enhancements] Com...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2496
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8789/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2496: [CARBONDATA-2737][Complex DataType Enhancements] Com...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2496
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/722/



---
12