[GitHub] carbondata pull request #2498: [CARBONDATA-2729][file-format] Schema Compati...

[qiuchenjian-2]

GitHub user mohammadshahidkhan opened a pull request:

    https://github.com/apache/carbondata/pull/2498

    [CARBONDATA-2729][file-format] Schema Compatibility problem between version 1.3.0 and 1.4.0

    **Problem**:
    In TableSchema the field Name schemaEvaluation is changed to schemaEvoluation and in DataMapSchema field name className is changed to providerName.
    Due to this current Carbon version & Version 1.4.0 is not able to properly de-serialize the schema created with older Carbon Version.
    **Solution**
     To de-serialize old schema having different field name the multiple values for SerializedName annotation can be used.
     For refrence please refer the [_**gson PR#699**_](https://github.com/google/gson/pull/699/).
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [X] Any interfaces changed?
     NA
     - [X] Any backward compatibility impacted?
     NA
     - [X] Document update required?
    NA
   
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           Added test case to verify de-serialization
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata store_compatibility

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2498.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2498
   
----
commit 12796bdfa6209f4da971d9b161b9bd426ad7c50f
Author: mohammadshahidkhan <mohdshahidkhan1987@...>
Date:   2018-07-02T14:21:03Z

    [CARBONDATA-2729][file-format] Schema Compatibility problem between version 1.3.0 and 1.4.0

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2498
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7053/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2498
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5830/



---

[qiuchenjian-2]

Github user KanakaKumar commented on the issue:

    https://github.com/apache/carbondata/pull/2498
 
    LGTM


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2498
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5797/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2498#discussion_r202221863
 
    --- Diff: core/pom.xml ---
    @@ -47,7 +47,7 @@
         <dependency>
           <groupId>com.google.code.gson</groupId>
           <artifactId>gson</artifactId>
    -      <version>2.3.1</version>
    +      <version>2.4</version>
    --- End diff --
   
    Can you check whether it is compatible with spark-2.3 also, as we will support spark-2.3 in near futreu.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2498
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7079/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2498
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5856/



---

[qiuchenjian-2]

Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2498#discussion_r202263586
 
    --- Diff: core/pom.xml ---
    @@ -47,7 +47,7 @@
         <dependency>
           <groupId>com.google.code.gson</groupId>
           <artifactId>gson</artifactId>
    -      <version>2.3.1</version>
    +      <version>2.4</version>
    --- End diff --
   
    I think if gson ensures backward comparability, it is independent of spark version.  


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2498
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2498


---