[GitHub] carbondata pull request #2501: [CARBONDATA-2738]Block Preaggregate, Dictiona...

[qiuchenjian-2]

GitHub user Indhumathi27 opened a pull request:

    https://github.com/apache/carbondata/pull/2501

    [CARBONDATA-2738]Block Preaggregate, Dictionary Exclude/Include for child columns for Complex datatype

    Block Preaggregate, Dictionary Exclude/Include for child columns for Complex datatype
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [x] Testing done
           Test cases added
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Indhumathi27/carbondata orderby

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2501.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2501
   
----
commit c962b84bd88a3afe695245653d7bc3f14d89c3ce
Author: Indhumathi27 <indhumathim27@...>
Date:   2018-07-12T15:41:11Z

    [CARBONDATA-2738]Block features for complex data type

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2501
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7071/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2501
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5846/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2501
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7076/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2501
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5853/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2501
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5813/



---

[qiuchenjian-2]

Github user akashrn5 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2501#discussion_r202285188
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala ---
    @@ -748,6 +748,10 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser {
           dictIncludeCols =
             tableProperties(CarbonCommonConstants.DICTIONARY_INCLUDE).split(",").map(_.trim)
           dictIncludeCols.foreach { distIncludeCol =>
    +        if (distIncludeCol.contains(".") || distIncludeCol.contains("[")) {
    --- End diff --
   
    same as above


---

[qiuchenjian-2]

Github user akashrn5 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2501#discussion_r202285088
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala ---
    @@ -720,18 +720,18 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser {
             tableProperties.get(CarbonCommonConstants.DICTIONARY_EXCLUDE).get.split(',').map(_.trim)
           dictExcludeCols
             .foreach { dictExcludeCol =>
    +          if (dictExcludeCol.contains(".") || dictExcludeCol.contains("[")) {
    --- End diff --
   
    do not check, for contains ".", get from field whether it is child column, then you can check whether that is given in include or exclude and throw exception


---

[qiuchenjian-2]

Github user akashrn5 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2501#discussion_r202286122
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala ---
    @@ -59,6 +60,13 @@ private[sql] case class CarbonProjectForUpdateCommand(
           return Seq.empty
         }
         val carbonTable = CarbonEnv.getCarbonTable(databaseNameOp, tableName)(sparkSession)
    +    columns.foreach { col =>
    +      var dataType = carbonTable.getColumnByName(tableName, col).getColumnSchema.getDataType
    +      if(dataType.getName.equals("STRUCT") || dataType.getName.equals("ARRAY")) {
    --- End diff --
   
    do not check for hard coded value, get the datatype and dicrectly check `isComplexType` and throw error


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2501
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5824/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2501
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5828/



---

[qiuchenjian-2]

Github user Indhumathi27 commented on the issue:

    https://github.com/apache/carbondata/pull/2501
 
    Retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2501
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7172/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2501
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5948/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2501
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5846/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2501
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5847/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2501
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7185/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2501
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5959/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2501
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7199/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2501
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5974/



---