[GitHub] carbondata pull request #2503: [CARBONDATA-2734] Update is not working on th...

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2503#discussion_r204272253
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -3235,4 +3235,17 @@ public boolean accept(CarbonFile file) {
         int version = fileHeader.getVersion();
         return ColumnarFormatVersion.valueOf((short)version);
       }
    +
    +  /**
    +   * Check whether it is standard table means tablepath has Fact/Part0/Segment_ tail present with
    +   * all carbon files. In other cases carbon files present directly under tablepath or
    +   * tablepath/partition folder
    +   * TODO Read segment file and corresponding index file to get the correct carbondata file instead
    +   * of using this way.
    +   * @param table
    +   * @return
    +   */
    +  public static boolean isStandardCarbonTable(CarbonTable table) {
    +    return !(table.isSupportFlatFolder() || table.isHivePartitionTable());
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2503
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2503


---