[GitHub] carbondata pull request #2507: [CABONDATA-2741]Fix for fetching random query...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2507
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7241/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2507#discussion_r202900184
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedVectorResultCollector.java ---
    @@ -109,13 +109,19 @@ void prepareDimensionAndMeasureColumnVectors() {
             allColumnInfo[queryDimensions[i].getOrdinal()] = columnVectorInfo;
           }
         }
    +    //skipping non existing measure columns in measureColumnInfo as here data filling to be done only on existing columns
    +    // for non existing column it is already been filled from restructure based collector
    +    int j = 0;
    --- End diff --
   
    Please handle in other implementation classes of `AbstractScannedResultCollector`


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2507
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6014/



---

[qiuchenjian-2]

Github user jatin9896 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2507#discussion_r202988752
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedVectorResultCollector.java ---
    @@ -109,13 +109,19 @@ void prepareDimensionAndMeasureColumnVectors() {
             allColumnInfo[queryDimensions[i].getOrdinal()] = columnVectorInfo;
           }
         }
    +    //skipping non existing measure columns in measureColumnInfo as here data filling to be done only on existing columns
    +    // for non existing column it is already been filled from restructure based collector
    +    int j = 0;
    --- End diff --
   
    @ravipesala
    For RestructureBasedDictionaryResultCollector already handled implementation of filling measure of  non existing and existing  column in method fillmeasureData which is correct handling.


---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2507
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2507
 
    LGTM


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2507
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7251/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2507
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5888/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2507
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6027/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2507
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7262/



---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2507


---