[GitHub] carbondata pull request #2521: [WIP] Fixed Thread leak issue in data loading

[qiuchenjian-2]

GitHub user kumarvishal09 opened a pull request:

    https://github.com/apache/carbondata/pull/2521

    [WIP] Fixed Thread leak issue in data loading

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kumarvishal09/incubator-carbondata threadleakfixNew

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2521.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2521
   
----
commit 58c51e37c08adc782b5e503a452531e4997351f4
Author: kumarvishal09 <kumarvishal1802@...>
Date:   2018-07-18T07:36:36Z

    Fixed Thread Leak Issue

commit 89bf7ec06b2478efd20bd8f03bf59f3c988c1c44
Author: kumarvishal09 <kumarvishal1802@...>
Date:   2018-07-18T07:39:47Z

    Fixed Thread Leak Issue

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2521
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7280/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2521
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6047/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2521
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5909/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2521#discussion_r203602958
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/DataWriterProcessorStepImpl.java ---
    @@ -184,12 +190,14 @@ private void processRange(Iterator<CarbonRowBatch> insideRangeIterator,
             dataHandler = CarbonFactHandlerFactory
                 .createCarbonFactHandler(model);
             dataHandler.initialise();
    +        carbonFactHandlers.add(dataHandler);
    --- End diff --
   
    Better add before initialize, so can you move this line above.


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2521#discussion_r203603034
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/DataWriterProcessorStepImpl.java ---
    @@ -80,6 +85,7 @@ public DataWriterProcessorStepImpl(CarbonDataLoadConfiguration configuration) {
       @Override public void initialize() throws IOException {
         super.initialize();
         child.initialize();
    +    this.carbonFactHandlers = new CopyOnWriteArrayList<>();
    --- End diff --
   
    Please do similar handing for `DataWriterBatchProcessorStepImpl` as well


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2521
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7317/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2521
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6081/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2521
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2521


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2521
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5927/



---