Apache CarbonData Dev Mailing List archive › Apache CarbonData JIRA issues

[GitHub] carbondata pull request #2524: Carbonstore migration spark2.3

Classic

List

Threaded

46 messages Options

123

qiuchenjian-2

[GitHub] carbondata pull request #2524: Carbonstore migration spark2.3

GitHub user sujith71955 opened a pull request:

https://github.com/apache/carbondata/pull/2524

Carbonstore migration spark2.3

## What changes were proposed in this pull request?
In this PR inorder to hide the compatibility issues of columnar vector API's from the existing common classes, i introduced an interface of the proxy vector readers, this
proxy vector readers will take care the compatibility issues with respect to spark different versions.
Column vector and Columnar Batch interface compatibility issues has been addressed in this PR, The changes were related to below modifications done in spark interface.

Highlights:
a) This is a refactoring of ColumnVector hierarchy and related classes.
b) make ColumnVector read-only
c) introduce WritableColumnVector with write interface
d) remove ReadOnlyColumnVector
e) Fixed spark-carbon integration API compatibility issues - By sandeep katta
f) Corrected the testcases based on spark 2.3.0 behaviour change - By sandeep katta
g) Excluded following dependency from pom.xml files <groupId>net.jpountz</groupId><artifactId>lz4</artifactId> as spark 2.3.0 changed
it to org.lz4, so removed from the test class path of spark2,spark-common-test,spark2-examples
- By sandeep katta
## How was this patch tested?
Manual testing, and existing test-case execution

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sujith71955/incubator-carbondata carbonstore_migration_spark2.3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2524.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2524

----
commit 088612753c8587c941d37a624b83decca447989d
Author: sujith71955 <sujithchacko.2010@...>
Date: 2018-05-24T05:51:50Z

[CARBONDATA-2532][Integration] Carbon to support spark 2.3 version, ColumnVector Interface

Column vector and Columnar Batch interface compatibility issues has been
addressed in this PR, The changes were related to below modifications
done in spark interface
a) This is a refactoring of ColumnVector hierarchy and related classes.
b) make ColumnVector read-only
c) introduce WritableColumnVector with write interface
d) remove ReadOnlyColumnVector

In this PR inorder to hide the compatibility issues of columnar vector
API's from the existing common classes, i introduced an interface of the
proxy vector readers, this
proxy vector readers will take care the compatibility issues with
respect to spark different versions.

# Conflicts:
# integration/spark2/src/main/java/org/apache/carbondata/spark/vectorreader/ColumnarVectorWrapper.java
# integration/spark2/src/main/java/org/apache/carbondata/spark/vectorreader/VectorizedCarbonRecordReader.java

commit b667e8d5613a23e50a39e918664a60624c646954
Author: sandeep-katta <sandeep.katta2007@...>
Date: 2018-07-06T04:31:29Z

[CARBONDATA-2532][Integration] Carbon to support spark 2.3 version, compatability issues

Changes continued..
All compatability issues when supporting 2.3 addressed
Supported pom profile -P"spark-2.3"

----

---

qiuchenjian-2