[GitHub] carbondata pull request #2537: [CARBONDATA-2768][CarbonStore] Fix error in t...

[qiuchenjian-2]

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2537

    [CARBONDATA-2768][CarbonStore] Fix error in tests for external csv format

    In previous implementation earlier than PR2495, we only supportted csv as
    external format for carbondata. And we validated the restriction while
    creating the table.PR2495 added kafka support, so it removed the
    validation, but it did not fix the related test case which cause failure in current version.
    This PR fix the error test case.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     `NO`
     - [x] Any backward compatibility impacted?
     `NO`
     - [x] Document update required?
    `NO`
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
    `Tests updated`
            - How it is tested? Please attach test report.
    `Tested in local`
            - Is it a performance related change? Please attach the performance test report.
    `NO`
            - Any additional information to help reviewers in testing this change.
           `NA`
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    `NA`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0723_fix_tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2537.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2537
   
----
commit a1ce8a15f1d3b2a1b4173137694a064cd7c04cb5
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-07-23T03:09:54Z

    Fix error in tests for external csv format
   
    In previous implementation earlier than PR2495, we only supportted csv as
    external format for carbondata. And we validated the restriction while
    creating the table.PR2495 added kafka support, so it removed the
    validation, but it did not fix the related test case which cause
    test failure in current version.
    This PR fix the error test case.

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2537
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7380/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2537
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5956/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2537
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6141/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2537#discussion_r204610009
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/statusmanager/FileFormatProperties.java ---
    @@ -17,10 +17,19 @@
     
     package org.apache.carbondata.core.statusmanager;
     
    +import java.util.HashSet;
    +import java.util.Set;
    +
     /**
      * Provides the constant name for the file format properties
      */
     public class FileFormatProperties {
    +  public static Set<String> SUPPORTED_EXTERNAL_FORMAT = new HashSet<String>() {
    --- End diff --
   
    better to make it private and provide function to validate whether user input format is supported


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2537#discussion_r204612717
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/statusmanager/FileFormatProperties.java ---
    @@ -17,10 +17,19 @@
     
     package org.apache.carbondata.core.statusmanager;
     
    +import java.util.HashSet;
    +import java.util.Set;
    +
     /**
      * Provides the constant name for the file format properties
      */
     public class FileFormatProperties {
    +  public static Set<String> SUPPORTED_EXTERNAL_FORMAT = new HashSet<String>() {
    --- End diff --
   
    OK


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2537#discussion_r204613470
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/statusmanager/FileFormatProperties.java ---
    @@ -17,10 +17,19 @@
     
     package org.apache.carbondata.core.statusmanager;
     
    +import java.util.HashSet;
    +import java.util.Set;
    +
     /**
      * Provides the constant name for the file format properties
      */
     public class FileFormatProperties {
    +  public static Set<String> SUPPORTED_EXTERNAL_FORMAT = new HashSet<String>() {
    --- End diff --
   
    OK


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2537
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7426/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2537
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6185/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2537
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2537
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7442/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2537
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6204/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2537
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2537
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7478/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2537
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6235/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2537
 
    please raise to external-format branch


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2537
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7761/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2537
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6486/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2537
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7762/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2537
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6144/



---