[GitHub] carbondata pull request #2551: [HOTFIX] Fix a spelling mistake after PR2511 ...

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2551: [HOTFIX] Fix a spelling mistake after PR2511 ...

qiuchenjian-2
GitHub user zzcclp opened a pull request:

    https://github.com/apache/carbondata/pull/2551

    [HOTFIX] Fix a spelling mistake after PR2511 merged.

    spelling mistakes: AtomicFileOperationsF
    use: AtomicFileOperationFactory.getAtomicFileOperations
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zzcclp/carbondata hotfix_AtomicFileOperationFactory

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2551.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2551
   
----
commit f25b03c13196ac792a3fe7bdbcd1c359dbd9eef0
Author: Zhang Zhichao <441586683@...>
Date:   2018-07-25T02:19:50Z

    [HOTFIX] Fix an error after PR2511 merged.
   
    spelling mistakes: AtomicFileOperationsF
    use: AtomicFileOperationFactory.getAtomicFileOperations

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2551: [HOTFIX] Fix a spelling mistake after PR2511 merged.

qiuchenjian-2
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2551
 
    @kunal642 @jackylk please review, thanks.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2551: [HOTFIX] Fix a spelling mistake after PR2511 merged.

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2551
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7475/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2551: [HOTFIX] Fix a spelling mistake after PR2511 merged.

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2551
 
    @zzcclp Thanks for the fix. I missed this somehow.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2551: [HOTFIX] Fix a spelling mistake after PR2511 merged.

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2551
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6232/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2551: [HOTFIX] Fix a spelling mistake after PR2511 merged.

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2551
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2551: [HOTFIX] Fix a spelling mistake after PR2511 ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2551


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2551: [HOTFIX] Fix a spelling mistake after PR2511 merged.

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2551
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5996/



---