[GitHub] carbondata pull request #2552: [CARBONDATA-2781] Added fix for Null Pointer ...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2552
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7618/



---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2552
 
    retest this please



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2552
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7643/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2552
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6367/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2552
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6385/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2552#discussion_r206458961
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala ---
    @@ -181,7 +181,18 @@ case class CarbonCreateDataMapCommand(
     
       override def undoMetadata(sparkSession: SparkSession, exception: Exception): Seq[Row] = {
         if (dataMapProvider != null) {
    -      dataMapProvider.cleanMeta()
    +      if (dataMapSchema.getProviderName
    --- End diff --
   
    I think datamap drop is required for all types of datamap , not just preaggregate


---

[qiuchenjian-2]

Github user praveenmeenakshi56 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2552#discussion_r206521693
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala ---
    @@ -181,7 +181,18 @@ case class CarbonCreateDataMapCommand(
     
       override def undoMetadata(sparkSession: SparkSession, exception: Exception): Seq[Row] = {
         if (dataMapProvider != null) {
    -      dataMapProvider.cleanMeta()
    +      if (dataMapSchema.getProviderName
    --- End diff --
   
    We need this check because we want the implementation of cleanMeta() method in PreAggregregateDataMapProvider. For others, It will take from IndexDataMapProvider


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2552#discussion_r206546864
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala ---
    @@ -181,7 +181,18 @@ case class CarbonCreateDataMapCommand(
     
       override def undoMetadata(sparkSession: SparkSession, exception: Exception): Seq[Row] = {
         if (dataMapProvider != null) {
    -      dataMapProvider.cleanMeta()
    +      if (dataMapSchema.getProviderName
    --- End diff --
   
    My suggestion is `CarbonDropDataMapCommand` should be called for all datamaps not just for pre-aggregate


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2552
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7707/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2552
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6433/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2552
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2552


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2552
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6099/



---