[GitHub] carbondata pull request #2554: [Documentation] Update document of bloom filt...

[qiuchenjian-2]

GitHub user kevinjmh opened a pull request:

    https://github.com/apache/carbondata/pull/2554

    [Documentation] Update document of bloom filter datamap

    add example for enable/disable datamap
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kevinjmh/carbondata doc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2554.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2554
   
----
commit 5f3abc5f31bd93b7c5d30856e16f269cf6098d42
Author: Manhua <kevinjmh@...>
Date:   2018-07-25T08:51:49Z

    update document of bloom filter

----


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2554#discussion_r205042798
 
    --- Diff: docs/datamap/bloomfilter-datamap-guide.md ---
    @@ -26,7 +26,16 @@ Showing all DataMaps on this table
       SHOW DATAMAP
       ON TABLE main_table
       ```
    -It will show all DataMaps created on main table.
    +
    +Enable Datamap
    +  ```
    +  SET carbon.datamap.visible.dbName.tableName.dataMapName = true
    +  ```
    +
    +Disable Datamap
    --- End diff --
   
    Please add more description about it. Such as
    ```
    We can disable a specific datamap during query to observe whether we can gain performance enhancement from it. This will only take effect current session.
    ```


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2554#discussion_r205043291
 
    --- Diff: docs/datamap/bloomfilter-datamap-guide.md ---
    @@ -26,7 +26,16 @@ Showing all DataMaps on this table
       SHOW DATAMAP
       ON TABLE main_table
       ```
    -It will show all DataMaps created on main table.
    +
    +Enable Datamap
    +  ```
    +  SET carbon.datamap.visible.dbName.tableName.dataMapName = true
    +  ```
    +
    +Disable Datamap
    +  ```
    +  SET carbon.datamap.visible.dbName.tableName.dataMapName = false
    --- End diff --
   
    please change it to
    ```
    // disable the datamap
    SET carbon.datamap.visible.dbName.tableName.dataMapName = false
    // enable the datamap
    SET carbon.datamap.visible.dbName.tableName.dataMapName = true
    ```


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2554#discussion_r205040479
 
    --- Diff: docs/datamap/bloomfilter-datamap-guide.md ---
    @@ -26,7 +26,16 @@ Showing all DataMaps on this table
       SHOW DATAMAP
       ON TABLE main_table
       ```
    -It will show all DataMaps created on main table.
    +
    +Enable Datamap
    --- End diff --
   
    We can ignore this section and only mention it is default


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2554
 
    JIRA ID is also needed


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2554
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7495/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2554
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6250/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2554
 
    LGTM


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2554
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7501/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2554
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6257/



---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2554


---