[GitHub] carbondata pull request #2577: [CARBONDATA-2796][32K]Fix data loading proble...

[qiuchenjian-2]

GitHub user kevinjmh opened a pull request:

    https://github.com/apache/carbondata/pull/2577

    [CARBONDATA-2796][32K]Fix data loading problem when table has complex column and long string column

    currently both varchar column and complex column believes itself is the last one member in noDictionary group when converting carbon row from raw format to 3-parted format. Since they need to be proceeded in different way, exception will occur if we deal the column in wrong way.
   
    To fix this, we mark the info of complex columns explicitly like varchar columns, and keep the order of noDictionary group as : normal Dim & varchar & complex
   
   
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kevinjmh/carbondata 32k_complex

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2577.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2577
   
----
commit b79610ac98b92e005a06c88e349195ae5b1c280b
Author: Manhua <kevinjmh@...>
Date:   2018-07-30T07:07:37Z

    fix varchar + complex data loading

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2577
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7600/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2577
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6061/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2577
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7616/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2577
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6359/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2577#discussion_r206414429
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/row/IntermediateSortTempRow.java ---
    @@ -54,35 +54,43 @@ public IntermediateSortTempRow(int[] dictSortDims, byte[][] noDictSortDims,
       /**
        * deserialize from bytes array to get the no sort fields
        * @param outDictNoSort stores the dict & no-sort fields
    -   * @param outNoDictNoSortAndVarcharDims stores the no-dict & no-sort fields,
    - *                                    including complex and varchar fields
    +   * @param outNoDictNoSort stores all no-dict & no-sort fields,
    + *                          including complex and varchar fields
        * @param outMeasures stores the measure fields
        * @param dataTypes data type for the measure
        */
    -  public void unpackNoSortFromBytes(int[] outDictNoSort, byte[][] outNoDictNoSortAndVarcharDims,
    -      Object[] outMeasures, DataType[] dataTypes, int varcharDimCnt) {
    +  public void unpackNoSortFromBytes(int[] outDictNoSort, byte[][] outNoDictNoSort,
    +      Object[] outMeasures, DataType[] dataTypes, int varcharDimCnt, int complexDimCnt) {
    --- End diff --
   
    add the comment doc for complexDimCnt


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2577
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7666/



---

[qiuchenjian-2]

Github user kevinjmh commented on the issue:

    https://github.com/apache/carbondata/pull/2577
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2577
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7676/



---

[qiuchenjian-2]

Github user kevinjmh commented on the issue:

    https://github.com/apache/carbondata/pull/2577
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2577
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6403/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2577
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7685/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2577
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6409/



---

[qiuchenjian-2]

Github user kevinjmh commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2577#discussion_r206796423
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/row/IntermediateSortTempRow.java ---
    @@ -54,35 +54,43 @@ public IntermediateSortTempRow(int[] dictSortDims, byte[][] noDictSortDims,
       /**
        * deserialize from bytes array to get the no sort fields
        * @param outDictNoSort stores the dict & no-sort fields
    -   * @param outNoDictNoSortAndVarcharDims stores the no-dict & no-sort fields,
    - *                                    including complex and varchar fields
    +   * @param outNoDictNoSort stores all no-dict & no-sort fields,
    + *                          including complex and varchar fields
        * @param outMeasures stores the measure fields
        * @param dataTypes data type for the measure
        */
    -  public void unpackNoSortFromBytes(int[] outDictNoSort, byte[][] outNoDictNoSortAndVarcharDims,
    -      Object[] outMeasures, DataType[] dataTypes, int varcharDimCnt) {
    +  public void unpackNoSortFromBytes(int[] outDictNoSort, byte[][] outNoDictNoSort,
    +      Object[] outMeasures, DataType[] dataTypes, int varcharDimCnt, int complexDimCnt) {
    --- End diff --
   
    fixed


---

[qiuchenjian-2]

Github user kevinjmh commented on the issue:

    https://github.com/apache/carbondata/pull/2577
 
    retest sdv please


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2577
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2577


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2577
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6101/



---