[GitHub] carbondata pull request #2589: [WIP][CARBONSTORE] add ParallelScanStore inte...

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/2589

    [WIP][CARBONSTORE] add ParallelScanStore interface

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata store-parallelscan

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2589.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2589
   
----
commit 458d3268fddfcb298c30f6bfa34a397e02b6f604
Author: Jacky Li <jacky.likun@...>
Date:   2018-07-30T16:23:19Z

    add ParallelScanStore interface

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2589
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7629/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2589
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6347/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2589
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7665/



---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2589#discussion_r206458466
 
    --- Diff: store/core/pom.xml ---
    @@ -48,8 +48,8 @@
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-compiler-plugin</artifactId>
             <configuration>
    -          <source>1.7</source>
    -          <target>1.7</target>
    +          <source>8</source>
    --- End diff --
   
    1.8 ?


---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/2589
 
    Can you explain "CTable" for what ?


---

[qiuchenjian-2]

Github user ajithme commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2589#discussion_r206492090
 
    --- Diff: store/core/pom.xml ---
    @@ -48,8 +48,8 @@
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-compiler-plugin</artifactId>
             <configuration>
    -          <source>1.7</source>
    -          <target>1.7</target>
    +          <source>8</source>
    --- End diff --
   
    8 is same as 1.8, as this is passed to javac
    https://docs.oracle.com/javase/8/docs/technotes/tools/windows/javac.html


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2589
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6397/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2589
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7689/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2589
 
    CTable is removed, now I have added new API in CarbonStore interface only


---

[qiuchenjian-2]

Github user jackylk closed the pull request at:

    https://github.com/apache/carbondata/pull/2589


---

[qiuchenjian-2]

GitHub user jackylk reopened a pull request:

    https://github.com/apache/carbondata/pull/2589

    [WIP][CARBONSTORE] Refactor CarbonStore API

    Interface of carbon prepared to integrate with Spark DatasourceV2
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata store-parallelscan

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2589.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2589
   
----
commit 6d08a5261037c762ea7b5297a22840c00689e890
Author: Jacky Li <jacky.likun@...>
Date:   2018-07-31T18:16:26Z

    modify CarbonStore API

commit 63e2c2cba4221f70c788325277b47b93bbc94de3
Author: Jacky Li <jacky.likun@...>
Date:   2018-07-31T18:39:45Z

    correct Horizon

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2589
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7690/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2589
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6416/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2589
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7694/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2589
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6421/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2589
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7695/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2589
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6088/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2589
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6089/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2589
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7713/



---