[GitHub] carbondata pull request #2593: [CARBONDATA-2753][Compatibility] Merge Index ...

[qiuchenjian-2]

GitHub user manishgupta88 opened a pull request:

    https://github.com/apache/carbondata/pull/2593

    [CARBONDATA-2753][Compatibility] Merge Index file not getting created with blocklet information for old store

    **Problem**
    Merge Index file not getting created with blocklet information for old store
   
    **Analysis**
    In legacy store (store <= 1.1 version), blocklet information is not written in the carbon Index files. When merge Index is created using the Alter DDL command on old store then merge Index file should be created with blocklet information which is as per the new store. This is not happening because the flag to read the carbondata file footer is not passed as true from Alter DDL command flow.
   
    **Fix**
    Pass the flag to read carbondataFileFooter as true while creating the merge Index file using Alter DDL command
   
     - [ ] Any interfaces changed?
     No
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    No
     - [ ] Testing done
    Manually verified      
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manishgupta88/carbondata merge_index_compatibility

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2593.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2593
   
----
commit 4af316a7cebd0f05a08c4f4519302961eccbcb1f
Author: manishgupta88 <tomanishgupta18@...>
Date:   2018-08-01T08:54:52Z

    Problem
    Merge Index file not getting created with blocklet information for old store
   
    Analysis
    In legacy store (store <= 1.1 version), blocklet information is not written in the carbon Index files. When merge Index is created using the Alter DDL command on old store then merge Index file should be created with blocklet information which is as per the new store. This is not happening because the flag to read the carbondata file footer is not passed as true from Alter DDL command flow.
   
    Fix
    Pass the flag to read carbondataFileFooter as true while creating the merge Index file using Alter DDL command

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2593
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7705/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2593
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6431/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2593
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6097/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2593
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2593


---