[GitHub] carbondata pull request #2599: [CARBONDATA-2812] Implement freeMemory for co...

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2599: [CARBONDATA-2812] Implement freeMemory for co...

qiuchenjian-2
GitHub user dhatchayani opened a pull request:

    https://github.com/apache/carbondata/pull/2599

    [CARBONDATA-2812] Implement freeMemory for complex pages

    **Problem:**
    The memory used by the ColumnPageWrapper (for complex data types) is not cleared and so it requires more memory to Load and Query.
   
    **Solution:**
    Clear the used memory in the freeMemory method.
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [x] Testing done
            Manual Testing
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhatchayani/carbondata CARBONDATA-2812

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2599.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2599
   
----
commit 28a9876274e97e71f7d65dcfbfce23fc173b6727
Author: dhatchayani <dhatcha.official@...>
Date:   2018-08-02T03:00:32Z

    [CARBONDATA-2812] Implement freeMemory for complex pages

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2599: [CARBONDATA-2812] Implement freeMemory for complex p...

qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2599
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6109/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2599: [CARBONDATA-2812] Implement freeMemory for complex p...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2599
 
    Retest sdv please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2599: [CARBONDATA-2812] Implement freeMemory for complex p...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2599
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7718/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2599: [CARBONDATA-2812] Implement freeMemory for complex p...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2599
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6444/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2599: [CARBONDATA-2812] Implement freeMemory for complex p...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2599
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6113/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2599: [CARBONDATA-2812] Implement freeMemory for complex p...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2599
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2599: [CARBONDATA-2812] Implement freeMemory for co...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2599


---