[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

classic Classic list List threaded Threaded
27 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

qiuchenjian-2
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2605#discussion_r208186221
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala ---
    @@ -641,6 +641,78 @@ object CarbonScalaUtil {
         }
       }
     
    +  /**
    +   * This method validates all the child columns of complex column recursively to check whether
    +   * any of the child column is of string dataType or not
    +   *
    +   * @param field
    +   */
    +  def validateChildColumnsRecursively(field: Field): Boolean = {
    +    if (field.children.isDefined && null != field.children.get) {
    +      field.children.get.exists { childColumn =>
    +        if (childColumn.children.isDefined && null != childColumn.children.get) {
    +          validateChildColumnsRecursively(childColumn)
    +        } else {
    +          childColumn.dataType.get.equalsIgnoreCase("string")
    +        }
    +      }
    +    } else {
    +      false
    +    }
    +  }
    +
    +  /**
    +   * This method validates the local dictionary configured columns
    +   *
    +   * @param fields
    --- End diff --
   
    please add parameter description for all newly added parameter


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2605: [CARBONDATA-2585] Fix local dictionary for both tabl...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2605
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6192/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2605: [CARBONDATA-2585] Fix local dictionary for both tabl...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2605
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2605: [CARBONDATA-2585] Fix local dictionary for both tabl...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2605
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6540/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2605: [CARBONDATA-2585] Fix local dictionary for both tabl...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2605
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7816/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2605: [CARBONDATA-2585] Fix local dictionary for both tabl...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/2605
 
    2.1 build has random failure, which is not related to this change


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2605: [CARBONDATA-2585] Fix local dictionary for bo...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2605


---
12