[GitHub] carbondata pull request #2606: [CARBONDATA-2817]Thread Leak in Update and in...

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2606#discussion_r208460810
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/CarbonRowDataWriterProcessorStepImpl.java ---
    @@ -169,38 +171,59 @@ private void doExecute(Iterator<CarbonRowBatch> iterator, int iteratorIndex) thr
           if (rowsNotExist) {
             rowsNotExist = false;
             dataHandler = CarbonFactHandlerFactory.createCarbonFactHandler(model);
    +        this.carbonFactHandlers.add(dataHandler);
             dataHandler.initialise();
           }
           processBatch(iterator.next(), dataHandler, iteratorIndex);
         }
    -    if (!rowsNotExist) {
    -      finish(dataHandler, iteratorIndex);
    +    try {
    +      if (!rowsNotExist) {
    +        finish(dataHandler, iteratorIndex);
    +      }
    +    } catch (CarbonDataWriterException e) {
    --- End diff --
   
    remove this catch block


---

[qiuchenjian-2]

Github user BJangir commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2606#discussion_r208515484
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/CarbonRowDataWriterProcessorStepImpl.java ---
    @@ -169,24 +171,36 @@ private void doExecute(Iterator<CarbonRowBatch> iterator, int iteratorIndex) thr
           if (rowsNotExist) {
             rowsNotExist = false;
             dataHandler = CarbonFactHandlerFactory.createCarbonFactHandler(model);
    +        this.carbonFactHandlers.add(dataHandler);
             dataHandler.initialise();
           }
           processBatch(iterator.next(), dataHandler, iteratorIndex);
         }
    -    if (!rowsNotExist) {
    -      finish(dataHandler, iteratorIndex);
    +    try {
    +      if (!rowsNotExist) {
    +        finish(dataHandler, iteratorIndex);
    +      }
    +    } finally {
    +      carbonFactHandlers.remove(dataHandler);
         }
    +
    +
       }
     
       @Override protected String getStepName() {
         return "Data Writer";
       }
     
       private void finish(CarbonFactHandler dataHandler, int iteratorIndex) {
    +    CarbonDataWriterException exception = null;
    --- End diff --
   
    Fixed


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2606
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6209/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2606
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7835/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2606
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6560/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2606
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2606


---