[GitHub] carbondata pull request #2612: [CARBONDATA-2834] Remove unnecessary nested l...

[qiuchenjian-2]

GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/2612

    [CARBONDATA-2834] Remove unnecessary nested looping over loadMetadatadetails.

    removed nested for loop which causes query performance degradation if…
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata nestedloop_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2612.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2612
   
----
commit ebe22d331dc4ea4ef6904e779702801c3eb5d859
Author: kunal642 <kunalkapoor642@...>
Date:   2018-08-06T12:47:28Z

    removed nested for loop which causes query performance degradation if number of segments are too many

----


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2612
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6183/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2612
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7804/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2612
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6528/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2612
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7810/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2612
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6534/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2612
 
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6535/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2612
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7811/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2612
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6187/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2612
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6188/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2612
 
    @kunal642 Please fix checkstyle


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2612#discussion_r208211297
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java ---
    @@ -779,6 +779,32 @@ public UpdateVO getInvalidTimestampRange(String segmentId) {
         }
         return range;
       }
    +
    +  /**
    +   * Returns the invalid timestamp range of a segment.
    +   * @return
    +   */
    +  public List<UpdateVO> getInvalidTimestampRange() {
    +    List<UpdateVO> ranges = new ArrayList<UpdateVO>();
    +    for (LoadMetadataDetails segment : segmentDetails) {
    +      if (!(segment.getSegmentStatus().equals(SegmentStatus.SUCCESS) ||
    +          segment.getSegmentStatus().equals(SegmentStatus.LOAD_PARTIAL_SUCCESS))) {
    --- End diff --
   
    Please refer SegmentStatusManager for checking the invalid segments


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2612
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6197/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2612
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7824/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2612
 
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6547/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2612
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2612


---