[GitHub] carbondata pull request #2663: [CARBONDATA-2894] Add support for complex map...

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    @ravipesala ...handled review comments. Kindly review and merge


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/185/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8256/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    LGTM


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2663#discussion_r214716461
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/Field.java ---
    @@ -213,4 +218,58 @@ public String getColumnComment() {
       public void setColumnComment(String columnComment) {
         this.columnComment = columnComment;
       }
    +
    +  private void initComplexTypeChildren() {
    +    if (getDataType().isComplexType()) {
    +      StructField subFields = prepareSubFields(getFieldName(), getDataType());
    +      if (DataTypes.isArrayType(getDataType()) || DataTypes.isMapType(getDataType())) {
    +        children = subFields.getChildren();
    +      } else if (DataTypes.isStructType(getDataType())) {
    +        children = ((StructType) subFields.getDataType()).getFields();
    +      }
    +    }
    +  }
    +
    +  /**
    +   * prepare sub fields for complex types
    +   *
    +   * @param fieldName
    +   * @param dType
    --- End diff --
   
    change to dataType and add all comment


---

[qiuchenjian-2]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2663#discussion_r214717788
 
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/Field.java ---
    @@ -213,4 +218,58 @@ public String getColumnComment() {
       public void setColumnComment(String columnComment) {
         this.columnComment = columnComment;
       }
    +
    +  private void initComplexTypeChildren() {
    +    if (getDataType().isComplexType()) {
    +      StructField subFields = prepareSubFields(getFieldName(), getDataType());
    +      if (DataTypes.isArrayType(getDataType()) || DataTypes.isMapType(getDataType())) {
    +        children = subFields.getChildren();
    +      } else if (DataTypes.isStructType(getDataType())) {
    +        children = ((StructType) subFields.getDataType()).getFields();
    +      }
    +    }
    +  }
    +
    +  /**
    +   * prepare sub fields for complex types
    +   *
    +   * @param fieldName
    +   * @param dType
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8266/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/195/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/17/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/160/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/328/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8399/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8405/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/166/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/168/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/336/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/334/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2663
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8407/



---