GitHub user kevinjmh opened a pull request:
https://github.com/apache/carbondata/pull/2676 [CARBONDATA-2902][DataMap] Fix showing negative pruning result for explain command Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kevinjmh/carbondata explain_block_level Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2676.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2676 ---- commit 50a15da1e1ab8165a1674e5ed6778ef18316628b Author: Manhua <kevinjmh@...> Date: 2018-08-31T03:44:10Z show different explain result for block/blocklet pruning ---- --- |
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2676 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8194/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2676 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/123/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2676 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/127/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2676 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8198/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2676 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8199/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2676 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/128/ --- |
In reply to this post by qiuchenjian-2
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2676#discussion_r214317180 --- Diff: core/src/main/java/org/apache/carbondata/core/profiler/ExplainCollector.java --- @@ -125,6 +125,13 @@ public static void addTotalBlocklets(int numBlocklets) { } } + public static void setDefaultDMBlockLevel(boolean isBlockLevel) { --- End diff -- please add comment --- |
In reply to this post by qiuchenjian-2
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2676#discussion_r214320712 --- Diff: core/src/main/java/org/apache/carbondata/core/profiler/TablePruningInfo.java --- @@ -99,4 +107,44 @@ public String toString() { } return builder.toString(); } + + /** + * when CACHE_LEVEL = BLOCK or carbon data file is LegacyStore + * only show pruned result size of datamaps in block/blocklet level + */ + private String getHitInfoAfterPruning() { + StringBuilder builder = new StringBuilder(); + builder + .append(" - total blocks: ").append(totalBlocklets).append("\n") + .append(" - filter: ").append(filterStatement).append("\n"); + if (defaultDataMap != null) { + builder + .append(" - pruned by Main DataMap").append("\n") + .append(" - hit blocks: ").append(numBlockletsAfterDefaultPruning).append("\n"); --- End diff -- It is better to unified with "blocklet case", you can change to use "hit blocklets" in `getSkipBlockletInfoAfterPruning` --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2676 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8248/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2676 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/177/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2676 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8258/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2676 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/187/ --- |
In reply to this post by qiuchenjian-2
|
In reply to this post by qiuchenjian-2
|
Free forum by Nabble | Edit this page |