[GitHub] carbondata pull request #2692: [CARBONDATA-2879] support sort scope for sdk

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2692#discussion_r215859359
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/LoadOption.java ---
    @@ -59,7 +59,6 @@
         optionsFinal.put("fileheader", Maps.getOrDefault(options, "fileheader", ""));
         optionsFinal.put("commentchar", Maps.getOrDefault(options, "commentchar", "#"));
         optionsFinal.put("columndict", Maps.getOrDefault(options, "columndict", null));
    -
    --- End diff --
   
    remove unnecessary changes from file


---

[qiuchenjian-2]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2692#discussion_r215861623
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java ---
    @@ -62,6 +62,7 @@
       /* Number of thread in which sdk writer is used */
       private short sdkUserCores;
     
    +
    --- End diff --
   
    done. removed


---

[qiuchenjian-2]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2692#discussion_r215861658
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/LoadOption.java ---
    @@ -59,7 +59,6 @@
         optionsFinal.put("fileheader", Maps.getOrDefault(options, "fileheader", ""));
         optionsFinal.put("commentchar", Maps.getOrDefault(options, "commentchar", "#"));
         optionsFinal.put("columndict", Maps.getOrDefault(options, "columndict", null));
    -
    --- End diff --
   
    done. removed


---

[qiuchenjian-2]

Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/2692
 
    @ravipesala : OK. removed empty lines.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2692
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/136/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2692
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.3/8374/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2692
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/304/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2692
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2692


---