GitHub user kevinjmh opened a pull request:
https://github.com/apache/carbondata/pull/2723 [CARBONDATA-2938][DataMap] Update comment of blockletId in IndexDataMapRebuildRDD
**Background**:
#2539 Tried to make use of blocklet id information from query when rebuilding datamap.
#2565 Revert PR2539 since it would cause wrong answer when testing on table with large mount of data
**What's in this PR**:
Update comment to explain why blocklet id information from query does not work
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/kevinjmh/carbondata rebuild_blockletid
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2723.patchTo close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2723
----
commit 786f743703d3dfb824bdddd12b9a29f9c16d3ef3
Author: Manhua <kevinjmh@...>
Date: 2018-09-15T02:30:00Z
update comment
----
---
Locked
