Apache CarbonData Dev Mailing List archive › Apache CarbonData JIRA issues

[GitHub] carbondata pull request #2729: [WIP]Store optimization

Classic

List

Threaded

124 messages Options

12345 ... 7

qiuchenjian-2

[GitHub] carbondata issue #2729: [WIP]Store optimization

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2729

Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8633/

---

qiuchenjian-2

[GitHub] carbondata issue #2729: [WIP]Store optimization

In reply to this post by qiuchenjian-2

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2729

Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/563/

---

qiuchenjian-2

[GitHub] carbondata issue #2729: [WIP]Store optimization

In reply to this post by qiuchenjian-2

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2729

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/390/

---

qiuchenjian-2

[GitHub] carbondata issue #2729: [WIP]Store optimization

In reply to this post by qiuchenjian-2

qiuchenjian-2

[GitHub] carbondata issue #2729: [WIP]Store optimization

In reply to this post by qiuchenjian-2

qiuchenjian-2

[GitHub] carbondata issue #2729: [WIP]Store optimization

In reply to this post by qiuchenjian-2

qiuchenjian-2

[GitHub] carbondata issue #2729: [WIP]Store optimization

In reply to this post by qiuchenjian-2

qiuchenjian-2

[GitHub] carbondata issue #2729: [WIP]Store optimization

In reply to this post by qiuchenjian-2

qiuchenjian-2

[GitHub] carbondata pull request #2729: [WIP]Store optimization

In reply to this post by qiuchenjian-2

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2729#discussion_r220160895

--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/BinaryDimColumnPage.java ---
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.carbondata.core.datastore.chunk.impl;
+
+import org.apache.carbondata.core.constants.CarbonCommonConstants;
+import org.apache.carbondata.core.datastore.chunk.store.DimensionChunkStoreFactory;
+import org.apache.carbondata.core.metadata.blocklet.PresenceMeta;
+import org.apache.carbondata.core.scan.result.vector.CarbonColumnVector;
+import org.apache.carbondata.core.scan.result.vector.ColumnVectorInfo;
+
+/**
+ * Class which holds and fill binary dimension column data
+ */
+public class BinaryDimColumnPage extends VariableLengthDimensionColumnPage {
--- End diff --

Can you use `ColumnPage` as the measure column currently is using it

---

qiuchenjian-2