[GitHub] carbondata pull request #2735: [CARBONDATA-2950]alter add column of hive tab...

classic Classic list List threaded Threaded
21 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2735: [CARBONDATA-2950]alter add column of hive tab...

qiuchenjian-2
GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/2735

    [CARBONDATA-2950]alter add column of hive table from carbon for spark versions above 2.1

    ### Problem:
    spark does not support add columns in spark-2.1, but it is supported in 2.2 and above
    when add column is fired for hive table in carbon session, for spark -version above 2.1, it throws error as unsupported operation on hive table
   
    ### Solution:
    when alter add columns for hive is fired for spark-2.2 and above, it should not throw any exception and it should pass
   
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     NA
     - [x] Any backward compatibility impacted?
     NA
     - [x] Document update required?
    NA
     - [x] Testing done
    Test case is added
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata alter

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2735.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2735
   
----
commit 05f53caa6d1a389eb6dce61359e800f81731966a
Author: akashrn5 <akashnilugal@...>
Date:   2018-09-19T14:21:39Z

    alter add column of hive table from carbon for spark versions above 2.1

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/362/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/363/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8610/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/540/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/367/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/372/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8614/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/544/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8619/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/549/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/394/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/571/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8641/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/397/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8645/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/575/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2735
 
    LGTM


---
12