[GitHub] carbondata pull request #2738: [CARBONDATA-2952] Provide c++ interface for S...

[qiuchenjian-2]

GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/2738

     [CARBONDATA-2952] Provide  c++  interface for SDK CarbonReader

   
     [CARBONDATA-2952] Provide CarbonReader C++ interface for SDK
        1.init carbonreader,config data path and tablename
        2.config ak sk endpoing for S3
        3.configure projection
        4.build carbon reader
        5.hasNext
        6.readNextRow
        7.close
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     Add C++ interface
     - [ ] Any backward compatibility impacted?
     independency
     - [ ] Document update required?
    Yes
     - [ ] Testing done
           test in main
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    this is sub-tasks  of  https://issues.apache.org/jira/browse/CARBONDATA-2951

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA-2952_CarbonReaderCppAPI

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2738.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2738
   
----
commit 49735f4f4d714eb76b124e20a1ee6c387b7be6aa
Author: xubo245 <xubo29@...>
Date:   2018-09-20T10:35:34Z

    [CARBONDATA-2952] Provide CarbonReader C++ interface for SDK
    1.init carbonreader,config data path and tablename
    2.config ak sk endpoing for S3
    3.configure projection
    4.build carbon reader
    5.hasNext
    6.readNextRow
    7.close

commit 11ebe2424f8f34d9e9168abcabf216bbce5a8dfa
Author: xubo245 <xubo29@...>
Date:   2018-09-20T10:52:14Z

    remove the debug folder

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2738
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/368/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2738
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/370/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2738
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/371/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2738
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/546/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2738
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8618/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2738
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/548/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2738
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8616/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2738
 
    is there a plan for supporting C ?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2738
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/395/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2738
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8643/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2738
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/573/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2738
 
    please mark it WIP if not ready


---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2738#discussion_r219700673
 
    --- Diff: store/CSDK/main.cpp ---
    @@ -0,0 +1,122 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +#include <stdio.h>
    +#include <jni.h>
    +#include <stdlib.h>
    +#include <iostream>
    +#include <unistd.h>
    +#include "CarbonReader.h"
    +
    +using namespace std;
    +
    +JavaVM *jvm;
    +
    +JNIEnv *initJVM() {
    +    JNIEnv *env;
    +    JavaVMInitArgs vm_args;
    +    int parNum = 3;
    +    int res;
    +    JavaVMOption options[parNum];
    +
    +    options[0].optionString = "-Djava.compiler=NONE";
    +    options[1].optionString = "-Djava.class.path=/Users/xubo/Desktop/xubo/git/c/test/jar/carbondata-sdk.jar";
    --- End diff --
   
    ？？？


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2738
 
    @zzcclp Now we plan support C++, do you need C interface of carbon?


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2738#discussion_r219873751
 
    --- Diff: store/CSDK/main.cpp ---
    @@ -0,0 +1,122 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +#include <stdio.h>
    +#include <jni.h>
    +#include <stdlib.h>
    +#include <iostream>
    +#include <unistd.h>
    +#include "CarbonReader.h"
    +
    +using namespace std;
    +
    +JavaVM *jvm;
    +
    +JNIEnv *initJVM() {
    +    JNIEnv *env;
    +    JavaVMInitArgs vm_args;
    +    int parNum = 3;
    +    int res;
    +    JavaVMOption options[parNum];
    +
    +    options[0].optionString = "-Djava.compiler=NONE";
    +    options[1].optionString = "-Djava.class.path=/Users/xubo/Desktop/xubo/git/c/test/jar/carbondata-sdk.jar";
    --- End diff --
   
    optimized


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2738
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/450/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2738
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/452/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2738
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/632/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2738
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8703/



---