[GitHub] carbondata pull request #2762: [CARBONDATA-2970]lock object creation fix for...

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2762: [CARBONDATA-2970]lock object creation fix for...

qiuchenjian-2
GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/2762

    [CARBONDATA-2970]lock object creation fix for viewFS

    ### Problem
    when default fs is set to ViewFS then the drop table and load fails with exception saying failed to get lock like meta.lock, tablestatus.lock. This is because when getting locktypeObject  we wre not checking for viewfs and we are returning it as local file system and failes while acquiring
   
    ### Solution
    Check for viewFS also when trying to get the lock object
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     NA
     - [x] Any backward compatibility impacted?
     NA
     - [x] Document update required?
    NA
     - [X] Testing done
    tested on three node cluster where defaultfs is set to viewFS
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    na


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata viewfs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2762.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2762
   
----
commit edbee616e60f5d59005a43208ed230e97e84a254
Author: akashrn5 <akashnilugal@...>
Date:   2018-09-25T13:29:04Z

    lock object correction for viewFS

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2762: [CARBONDATA-2970]lock object creation fix for viewFS

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2762
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/486/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2762: [CARBONDATA-2970]lock object creation fix for viewFS

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2762
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8738/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2762: [CARBONDATA-2970]lock object creation fix for viewFS

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2762
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/672/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2762: [CARBONDATA-2970]lock object creation fix for viewFS

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2762
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8761/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2762: [CARBONDATA-2970]lock object creation fix for viewFS

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2762
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/694/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2762: [CARBONDATA-2970]lock object creation fix for viewFS

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2762
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/520/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2762: [CARBONDATA-2970]lock object creation fix for viewFS

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/2762
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2762: [CARBONDATA-2970]lock object creation fix for viewFS

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2762
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/598/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2762: [CARBONDATA-2970]lock object creation fix for viewFS

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2762
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8857/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2762: [CARBONDATA-2970]lock object creation fix for viewFS

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2762
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/790/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2762: [CARBONDATA-2970]lock object creation fix for viewFS

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2762
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2762: [CARBONDATA-2970]lock object creation fix for...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2762


---