[GitHub] carbondata pull request #2765: [CARBONDATA-2971] Add shard info of blocklet ...

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2765: [CARBONDATA-2971] Add shard info of blocklet ...

qiuchenjian-2
GitHub user kevinjmh opened a pull request:

    https://github.com/apache/carbondata/pull/2765

    [CARBONDATA-2971] Add shard info of blocklet for debugging

    add `toString` method to print both shard name and blocklet id for debugging.
   
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kevinjmh/carbondata addDebugInfo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2765.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2765
   
----
commit 225ea72f16fafe5d16192763d01614822f31e2dd
Author: Manhua <kevinjmh@...>
Date:   2018-09-26T02:34:54Z

    add toString

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2765: [CARBONDATA-2971] Add shard info of blocklet for deb...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2765
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/496/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2765: [CARBONDATA-2971] Add shard info of blocklet for deb...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2765
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8745/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2765: [CARBONDATA-2971] Add shard info of blocklet for deb...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2765
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/676/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2765: [CARBONDATA-2971] Add shard info of blocklet for deb...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2765
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2765: [CARBONDATA-2971] Add shard info of blocklet ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2765#discussion_r220446454
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/Blocklet.java ---
    @@ -92,7 +95,13 @@ public String getFilePath() {
             blocklet.blockletId == null;
       }
     
    -  @Override public int hashCode() {
    +  @Override
    +  public String toString() {
    +    return String.format("[shard:%s, blockletId:%s]", filePath, blockletId);
    --- End diff --
   
    You can use CarbonTablePath.getShardName to get the shard name


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2765: [CARBONDATA-2971] Add shard info of blocklet ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kevinjmh commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2765#discussion_r220455196
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/Blocklet.java ---
    @@ -92,7 +95,13 @@ public String getFilePath() {
             blocklet.blockletId == null;
       }
     
    -  @Override public int hashCode() {
    +  @Override
    +  public String toString() {
    +    return String.format("[shard:%s, blockletId:%s]", filePath, blockletId);
    --- End diff --
   
    The shard name in `toString()` is exactly the one in `Blocklet` itself


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2765: [CARBONDATA-2971] Add shard info of blocklet ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2765#discussion_r220488388
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/Blocklet.java ---
    @@ -92,7 +95,13 @@ public String getFilePath() {
             blocklet.blockletId == null;
       }
     
    -  @Override public int hashCode() {
    +  @Override
    +  public String toString() {
    +    return String.format("[shard:%s, blockletId:%s]", filePath, blockletId);
    --- End diff --
   
    so I think you can change the implementation of toString, just use the common toString method generated by the editor.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2765: [CARBONDATA-2971] Add shard info of blocklet ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kevinjmh commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2765#discussion_r220490591
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/Blocklet.java ---
    @@ -92,7 +95,13 @@ public String getFilePath() {
             blocklet.blockletId == null;
       }
     
    -  @Override public int hashCode() {
    +  @Override
    +  public String toString() {
    +    return String.format("[shard:%s, blockletId:%s]", filePath, blockletId);
    --- End diff --
   
    updated


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2765: [CARBONDATA-2971] Add shard info of blocklet for deb...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2765
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/692/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2765: [CARBONDATA-2971] Add shard info of blocklet for deb...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2765
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8759/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2765: [CARBONDATA-2971] Add shard info of blocklet for deb...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kevinjmh commented on the issue:

    https://github.com/apache/carbondata/pull/2765
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2765: [CARBONDATA-2971] Add shard info of blocklet for deb...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2765
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/519/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2765: [CARBONDATA-2971] Add shard info of blocklet for deb...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2765
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8850/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2765: [CARBONDATA-2971] Add shard info of blocklet for deb...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2765
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/783/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2765: [CARBONDATA-2971] Add shard info of blocklet for deb...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2765
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2765: [CARBONDATA-2971] Add shard info of blocklet ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2765


---