[GitHub] carbondata pull request #2767: [CARBONDATA-2974] Fixed multiple expressions ...

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2767
 
    Fixed it, now passes only required expressions. Please check
    ---
    No, for example NotEqualExpression will be passed to the BloomDataMap.createQueryModel method too


---

[qiuchenjian-2]

Github user kevinjmh commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2767#discussion_r221123795
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapChooser.java ---
    @@ -282,7 +280,9 @@ private void extractColumnExpression(Expression expression,
           List<Expression> children = expression.getChildren();
           if (children != null && children.size() > 0) {
             for (Expression exp : children) {
    -          extractColumnExpression(exp, columnExpressions);
    +          if (exp != null && exp.getFilterExpressionType() != ExpressionType.UNKNOWN) {
    --- End diff --
   
    I'am not sure whether any **other** expression exists like SparkUnknownExpression( which is under EqualToExpression/InExpression and  has a child of ColumnExpression   )


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2767
 
    LGTM


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2767
 
    After discussed with @kevinjmh offline, we agreed that this PR fixed the problem as far as we considered. So I will merge this PR.


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2767


---