[GitHub] carbondata pull request #2768: [HOTFIX] Do not add InvertedIndex in Encoding...

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/2768

    [HOTFIX] Do not add InvertedIndex in Encoding list for non-sort dimension column

    For test
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata invertedindex

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2768.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2768
   
----
commit 7e45bbd23973723447ec46e58c5c7e33a2ecd85e
Author: Jacky Li <jacky.likun@...>
Date:   2018-09-26T13:31:35Z

    Not add InvertedIndex in Encoding list for non-sort dimension column

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2768
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/517/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2768
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8848/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2768
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/781/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2768#discussion_r220964343
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java ---
    @@ -224,7 +224,7 @@ private ColumnSchema addColumn(StructField field, String parentName, AtomicInteg
             }
           }
         }
    -    if (newColumn.isDimensionColumn()) {
    +    if (newColumn.isDimensionColumn() && newColumn.isSortColumn()) {
    --- End diff --
   
    @jackylk In case of no sort , isSortColumn will be true for all the dimension columns. so above check is of no use.
    So I suggest to do like below.
    In case of no sort for each dimension column we have set isSortColumn to false  and keep your condition


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2768#discussion_r221411345
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java ---
    @@ -224,7 +224,7 @@ private ColumnSchema addColumn(StructField field, String parentName, AtomicInteg
             }
           }
         }
    -    if (newColumn.isDimensionColumn()) {
    +    if (newColumn.isDimensionColumn() && newColumn.isSortColumn()) {
    --- End diff --
   
    When I change CarbonCliTest to write carbon files with no sort,
    ```
    TestUtil.writeFilesAndVerify(5000000, new Schema(fields), path, new String[0], 3, 8);
    ```
    The output of the CarbonCli is
    ```
    ## Schema
    schema in part-0-31810056985663_batchno0-0-null-31809010599854.carbondata
    version: V3
    timestamp: 2018-09-29 09:41:19.839
    Column Name  Data Type  Column Type  SortColumn  Encoding  Ordinal  Id  
    name         STRING     dimension    false       []        0        NA  
    age          INT        measure      false       []        1        NA  
    ```
    So it indicate that the sort columns property in each ColumnSchema is false, right?


---

[qiuchenjian-2]

Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2768
 
    retest this please



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2768
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/692/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2768
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8957/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2768
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/889/



---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/2768
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2768
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/697/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2768
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/894/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2768
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8962/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2768#discussion_r222629503
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java ---
    @@ -224,7 +224,7 @@ private ColumnSchema addColumn(StructField field, String parentName, AtomicInteg
             }
           }
         }
    -    if (newColumn.isDimensionColumn()) {
    +    if (newColumn.isDimensionColumn() && newColumn.isSortColumn()) {
    --- End diff --
   
    Okay its fine


---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2768
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2768


---