[GitHub] carbondata pull request #2788: [Documentation] Readme updated with latest to...

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2788#discussion_r222632733
 
    --- Diff: docs/carbon-as-spark-datasource-guide.md ---
    @@ -15,19 +15,20 @@
         limitations under the License.
     -->
    --- End diff --
   
    where is the link added?


---

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2788#discussion_r222635144
 
    --- Diff: docs/carbon-as-spark-datasource-guide.md ---
    @@ -15,19 +15,20 @@
         limitations under the License.
     -->
     
    -# Carbon as Spark's datasource guide
    +# CarbonData as Spark's Datasource
     
    -Carbon fileformat can be integrated to Spark using datasource to read and write data without using CarbonSession.
    +The CarbonData fileformat is now integrated as Spark datasource for read and write operation without using CarbonSession. This is useful for users who wants to use carbondata as spark's data source.
     
    +**Note:** You can only apply the features of Spark datasource similar to Parquet. The carbon session features are not supported.
    --- End diff --
   
    functions/features supported by spark data source APIs.Functionalities supported would be similar to Parquet


---

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2788#discussion_r222635398
 
    --- Diff: docs/ddl-of-carbondata.md ---
    @@ -610,25 +611,29 @@ Users can specify which columns to include and exclude for local dictionary gene
        - ##### DROP COLUMNS
       
          This command is used to delete the existing column(s) in a table.
    -     ```
    +    
    + ```
    --- End diff --
   
    why indentation for ```


---

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2788#discussion_r222635573
 
    --- Diff: docs/ddl-of-carbondata.md ---
    @@ -610,25 +611,29 @@ Users can specify which columns to include and exclude for local dictionary gene
        - ##### DROP COLUMNS
       
          This command is used to delete the existing column(s) in a table.
    -     ```
    +    
    + ```
    --- End diff --
   
    why indentation for ```


---

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2788#discussion_r222638371
 
    --- Diff: docs/ddl-of-carbondata.md ---
    @@ -610,25 +611,29 @@ Users can specify which columns to include and exclude for local dictionary gene
        - ##### DROP COLUMNS
       
          This command is used to delete the existing column(s) in a table.
    -     ```
    +    
    + ```
          ALTER TABLE [db_name.]table_name DROP COLUMNS (col_name, ...)
          ```
     
          Examples:
    -     ```
    +    
    + ```
    --- End diff --
   
    unnecessary indentation for ```


---

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2788#discussion_r222638442
 
    --- Diff: docs/ddl-of-carbondata.md ---
    @@ -610,25 +611,29 @@ Users can specify which columns to include and exclude for local dictionary gene
        - ##### DROP COLUMNS
       
          This command is used to delete the existing column(s) in a table.
    -     ```
    +    
    + ```
          ALTER TABLE [db_name.]table_name DROP COLUMNS (col_name, ...)
          ```
     
          Examples:
    -     ```
    +    
    + ```
          ALTER TABLE carbon DROP COLUMNS (b1)
          OR
          ALTER TABLE test_db.carbon DROP COLUMNS (b1)
         
          ALTER TABLE carbon DROP COLUMNS (c1,d1)
          ```
    -     NOTE: Drop Complex child column is not supported.
    +
    +     **NOTE:** Drop Complex child column is not supported.
     
        - ##### CHANGE DATA TYPE
       
          This command is used to change the data type from INT to BIGINT or decimal precision from lower to higher.
          Change of decimal data type from lower precision to higher precision will only be supported for cases where there is no data loss.
    -     ```
    +    
    + ```
    --- End diff --
   
    unnecessary indentation for ```


---

[qiuchenjian-2]

Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2788#discussion_r222638610
 
    --- Diff: docs/ddl-of-carbondata.md ---
    @@ -610,25 +611,29 @@ Users can specify which columns to include and exclude for local dictionary gene
        - ##### DROP COLUMNS
       
          This command is used to delete the existing column(s) in a table.
    -     ```
    +    
    + ```
          ALTER TABLE [db_name.]table_name DROP COLUMNS (col_name, ...)
          ```
     
          Examples:
    -     ```
    +    
    + ```
          ALTER TABLE carbon DROP COLUMNS (b1)
          OR
          ALTER TABLE test_db.carbon DROP COLUMNS (b1)
         
          ALTER TABLE carbon DROP COLUMNS (c1,d1)
          ```
    -     NOTE: Drop Complex child column is not supported.
    +
    +     **NOTE:** Drop Complex child column is not supported.
     
        - ##### CHANGE DATA TYPE
       
          This command is used to change the data type from INT to BIGINT or decimal precision from lower to higher.
          Change of decimal data type from lower precision to higher precision will only be supported for cases where there is no data loss.
    -     ```
    +    
    + ```
    --- End diff --
   
    correct in other places as well


---

[qiuchenjian-2]

Github user sgururajshetty commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2788#discussion_r222666063
 
    --- Diff: docs/carbon-as-spark-datasource-guide.md ---
    @@ -41,25 +42,23 @@ Carbon table can be created with spark's datasource DDL syntax as follows.
     
     | Property | Default Value | Description |
     |-----------|--------------|------------|
    -| table_blocksize | 1024 | Size of blocks to write onto hdfs |
    +| table_blocksize | 1024 | Size of blocks to write onto hdfs. For  more details, see [Table Block Size Configuration](./ddl-of-carbondata.md#table-block-size-configuration) |
    --- End diff --
   
    Added reference to all properties


---

[qiuchenjian-2]

Github user sgururajshetty commented on the issue:

    https://github.com/apache/carbondata/pull/2788
 
    @sraghunandan kindly review the PR and help me to merge the same


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2788
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/719/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2788
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/720/



---

[qiuchenjian-2]

Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/2788
 
    LGTM


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2788
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8984/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2788
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/916/



---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2788
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2788


---