[GitHub] carbondata pull request #2792: [CARBONDATA-2981] Support read primitive data...

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2792#discussion_r223238726
 
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonRecordReader.java ---
    @@ -116,6 +117,25 @@ public void initialize(InputSplit inputSplit, TaskAttemptContext context)
         return readSupport.readRow(carbonIterator.next());
       }
     
    +  /**
    +   * get CarbonRow data, including data and datatypes
    +   *
    +   * @return carbonRow object or data array or T
    +   * @throws IOException
    +   * @throws InterruptedException
    +   */
    +  public T getCarbonRow() throws IOException, InterruptedException {
    --- End diff --
   
    ok, done


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2792#discussion_r223240030
 
    --- Diff: store/CSDK/CarbonReader.cpp ---
    @@ -89,10 +89,18 @@ jboolean CarbonReader::hasNext() {
         return hasNext;
     }
     
    +jobject CarbonReader::readNextCarbonRow() {
    +    jclass carbonReader = jniEnv->GetObjectClass(carbonReaderObject);
    +    jmethodID readNextCarbonRowID = jniEnv->GetMethodID(carbonReader, "readNextCarbonRow",
    +        "()Lorg/apache/carbondata/core/datastore/row/CarbonRow;");
    +    jobject carbonRow = (jobject) jniEnv->CallObjectMethod(carbonReaderObject, readNextCarbonRowID);
    +    return carbonRow;
    +}
    +
     jobjectArray CarbonReader::readNextRow() {
         jclass carbonReader = jniEnv->GetObjectClass(carbonReaderObject);
    -    jmethodID readNextRow2ID = jniEnv->GetMethodID(carbonReader, "readNextStringRow", "()[Ljava/lang/Object;");
    -    jobjectArray row = (jobjectArray) jniEnv->CallObjectMethod(carbonReaderObject, readNextRow2ID);
    +    jmethodID readNextStringRowID = jniEnv->GetMethodID(carbonReader, "readNextStringRow", "()[Ljava/lang/Object;");
    --- End diff --
   
    I removed readNextStringRow in java code and readNextRow in c code


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2792
 
    @kunal642 OK，added


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2792
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/733/



---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2792#discussion_r223243327
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/row/CarbonRow.java ---
    @@ -18,8 +18,11 @@
     package org.apache.carbondata.core.datastore.row;
     
     import java.io.Serializable;
    +import java.math.BigDecimal;
    --- End diff --
   
    ok, I added


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2792#discussion_r223244987
 
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/readsupport/impl/DictionaryDecodeReadSupport.java ---
    @@ -81,7 +82,24 @@
             data[i] = dictionaries[i].getDictionaryValueForKey((int) data[i]);
           }
         }
    -    return (T)data;
    +    return (T) data;
    +  }
    +
    +  /**
    +   * get carbonRow, including data and datatpes
    +   *
    +   * @param data row data
    +   * @return CarbonRow Object
    +   */
    +  public T readCarbonRow(Object[] data) {
    --- End diff --
   
    I add Row class and optimized readCarbonRow method


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2792
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/735/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2792
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/932/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2792
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9000/



---

[qiuchenjian-2]

Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2792#discussion_r223260021
 
    --- Diff: README.md ---
    @@ -52,6 +52,7 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com
     * [Configuring Carbondata](https://github.com/apache/carbondata/blob/master/docs/configuration-parameters.md)
     * [Streaming Ingestion](https://github.com/apache/carbondata/blob/master/docs/streaming-guide.md)
     * [SDK Guide](https://github.com/apache/carbondata/blob/master/docs/sdk-guide.md)
    +* [CSDK Guide](https://github.com/apache/carbondata/blob/master/docs/CSDK-guide.md)
    --- End diff --
   
    Other places also have to be update with this link like documentation.md. can you refer sdk-guide.md and update other places as well.


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2792#discussion_r223267582
 
    --- Diff: README.md ---
    @@ -52,6 +52,7 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com
     * [Configuring Carbondata](https://github.com/apache/carbondata/blob/master/docs/configuration-parameters.md)
     * [Streaming Ingestion](https://github.com/apache/carbondata/blob/master/docs/streaming-guide.md)
     * [SDK Guide](https://github.com/apache/carbondata/blob/master/docs/sdk-guide.md)
    +* [CSDK Guide](https://github.com/apache/carbondata/blob/master/docs/CSDK-guide.md)
    --- End diff --
   
    ok, done. I only find documentation.md. CSDK don't support write, so other place no need to update.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2792
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/736/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2792
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9001/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2792
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/933/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2792
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/748/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2792
 
    @KanakaKumar I optimize this PR. remove change in carbonRecordReader and add static method in RowUtil.
   
    I will raise a new PR for reading schema


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2792
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/749/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2792
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9015/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2792
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/947/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2792
 
    retest this please


---