[GitHub] carbondata pull request #2801: [DOC] Add document for TABLE_BLOCKLET_SIZE

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/2801

    [DOC] Add document for TABLE_BLOCKLET_SIZE

    Document for table property TABLE_BLOCKLET_SIZE is added
   
     - [X] Any interfaces changed?
     No
     - [X] Any backward compatibility impacted?
     No
     - [X] Document update required?
    Yes
     - [X] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata blocklet_size

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2801.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2801
   
----
commit 51f38c1bfa25ad6daa20840bb448dd494f7e0edd
Author: Jacky Li <jacky.likun@...>
Date:   2018-10-08T08:14:33Z

    add doc

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2801
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/737/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2801
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/935/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2801
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9003/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2801
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/743/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2801
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9009/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2801
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/941/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2801#discussion_r223623791
 
    --- Diff: docs/ddl-of-carbondata.md ---
    @@ -173,14 +174,24 @@ CarbonData DDL statements are documented here,which includes:
     
        - ##### Table Block Size Configuration
     
    -     This command is for setting block size of this table, the default value is 1024 MB and supports a range of 1 MB to 2048 MB.
    +     This property is for setting block size of this table, the default value is 1024 MB and supports a range of 1 MB to 2048 MB.
     
          ```
          TBLPROPERTIES ('TABLE_BLOCKSIZE'='512')
          ```
    -
    +
          **NOTE:** 512 or 512M both are accepted.
     
    +   - ##### Table Blocklet Size Configuration
    +
    +     This property is for setting blocklet size in the carbondata file, the default value is 64 MB.
    +     Blocklet is the minimum IO read unit, so the smaller the value, the better it is for filtering queries.
    --- End diff --
   
    I feel this statement may mislead users because if we reduce IO unit size, number of IO operations become more and it hits the performance.  It would be better in case of point queries not all filter queries, so better mention point queries not all filter queries


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2801#discussion_r223908902
 
    --- Diff: docs/ddl-of-carbondata.md ---
    @@ -173,14 +174,24 @@ CarbonData DDL statements are documented here,which includes:
     
        - ##### Table Block Size Configuration
     
    -     This command is for setting block size of this table, the default value is 1024 MB and supports a range of 1 MB to 2048 MB.
    +     This property is for setting block size of this table, the default value is 1024 MB and supports a range of 1 MB to 2048 MB.
     
          ```
          TBLPROPERTIES ('TABLE_BLOCKSIZE'='512')
          ```
    -
    +
          **NOTE:** 512 or 512M both are accepted.
     
    +   - ##### Table Blocklet Size Configuration
    +
    +     This property is for setting blocklet size in the carbondata file, the default value is 64 MB.
    +     Blocklet is the minimum IO read unit, so the smaller the value, the better it is for filtering queries.
    --- End diff --
   
    ok, fixed


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2801
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/755/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2801
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9021/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2801
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/953/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2801
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2801


---