[GitHub] carbondata pull request #2817: [CARBONDATA-3009] Move method for mergeIndex ...

[qiuchenjian-2]

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2817

    [CARBONDATA-3009] Move method for mergeIndex to correct the place

    Currently the entry point of function for mergeIndex is in `CommonUtil`
    which is not proper. Here in this commit, we will move this to the right
    place.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     `only internal interface has been changed`
     - [x] Any backward compatibility impacted?
     `NO`
     - [x] Document update required?
    `NO`
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
    `Not required. We just moved the method from one place to another`
            - How it is tested? Please attach test report.
    `Tested in local`
            - Is it a performance related change? Please attach the performance test report.
    `NO`
            - Any additional information to help reviewers in testing this change.
    `We should provide the interfaces and functions in proper place and avoid god-class`
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    `NA`
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 181016_opt_merge_index_method

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2817.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2817
   
----
commit 1d1f6ad61d1a44f5cf78dac659f90347fe4f1a0c
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-10-16T06:57:16Z

    Move method for mergeIndex to correct the place
   
    Currently the entry point of function for mergeIndex is in `CommonUtil`
    which is not proper. Here in this commit, we will move this to the right
    place.

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2817
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/796/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2817
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9061/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2817
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/993/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2817#discussion_r225914270
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/rdd/CarbonMergeFilesRDD.scala ---
    @@ -34,6 +36,59 @@ case class CarbonMergeFilePartition(rddId: Int, idx: Int, segmentId: String)
       override def hashCode(): Int = 41 * (41 + rddId) + idx
     }
     
    +object CarbonMergeFilesRDD {
    +  /**
    +   * Merge the carbonindex files with in the segment to carbonindexmerge file inside same segment
    +   *
    +   * @param readFileFooterFromCarbonDataFile flag to read file footer information from carbondata
    +   *                                         file. This will used in case of upgrade from version
    +   *                                         which do not store the blocklet info to current
    +   *                                         version
    +   */
    +  def mergeIndexFiles(sparkSession: SparkSession,
    +      segmentIds: Seq[String],
    --- End diff --
   
    please add doc for all parameter


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2817
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/849/



---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2817#discussion_r226200613
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/rdd/CarbonMergeFilesRDD.scala ---
    @@ -34,6 +36,59 @@ case class CarbonMergeFilePartition(rddId: Int, idx: Int, segmentId: String)
       override def hashCode(): Int = 41 * (41 + rddId) + idx
     }
     
    +object CarbonMergeFilesRDD {
    +  /**
    +   * Merge the carbonindex files with in the segment to carbonindexmerge file inside same segment
    +   *
    +   * @param readFileFooterFromCarbonDataFile flag to read file footer information from carbondata
    +   *                                         file. This will used in case of upgrade from version
    +   *                                         which do not store the blocklet info to current
    +   *                                         version
    +   */
    +  def mergeIndexFiles(sparkSession: SparkSession,
    +      segmentIds: Seq[String],
    --- End diff --
   
    OK~


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2817
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/851/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2817
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9114/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2817
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1046/



---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2817


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2817
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9116/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2817
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1048/



---