[GitHub] carbondata pull request #2830: [CARBONDATA-3025]Added CLI enhancements

[qiuchenjian-2]

Github user akashrn5 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2830#discussion_r228123785
 
    --- Diff: tools/cli/src/main/java/org/apache/carbondata/tool/DataSummary.java ---
    @@ -226,25 +282,46 @@ private int getColumnIndex(String columnName) {
       private boolean collected = false;
     
       private void printColumnStats(String columnName) throws IOException, MemoryException {
    -    out.println();
    -    out.println("## Column Statistics for '" + columnName + "'");
    +    outPuts.add("");
    +    outPuts.add("## Column Statistics for '" + columnName + "'");
         collectStats(columnName);
     
         int columnIndex = getColumnIndex(columnName);
         String[] header = new String[]{"BLK", "BLKLT", "Meta Size", "Data Size",
    -        "LocalDict", "DictEntries", "DictSize", "AvgPageSize", "Min%", "Max%"};
    +        "LocalDict", "DictEntries", "DictSize", "AvgPageSize", "Min%", "Max%", "Min", "Max"};
     
    -    ShardPrinter printer = new ShardPrinter(header);
    +    ShardPrinter printer = new ShardPrinter(header, outPuts);
         for (Map.Entry<String, DataFile> entry : dataFiles.entrySet()) {
           DataFile file = entry.getValue();
           for (DataFile.Blocklet blocklet : file.getAllBlocklets()) {
    -        String min, max;
    +        String min, max, minPercent, maxPercent;
    --- End diff --
   
    handled


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2830
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1225/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2830
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9277/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2830
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1018/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2830
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1231/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2830
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9283/



---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2830
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2830


---