[GitHub] carbondata pull request #2842: [CARBONDATA-3032] Remove carbon.blocklet.size...

[qiuchenjian-2]

GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/2842

    [CARBONDATA-3032] Remove carbon.blocklet.size from properties template

    1.Remove carbon.blocklet.size from properties template, because carbon.blocklet.size is in V2, V3 use carbon.blockletgroup.size.in.mb or page size
    2.change numberComressor to numberCompressor
    3.optimize the annotation of method
   
   
     - [ ] Any interfaces changed?
     No
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    No
     - [ ] Testing done
          No
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA-3032_removeBlockletSize

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2842.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2842
   
----
commit 90dfad9a443ae1e5fd791fac85b73096598ab87e
Author: xubo245 <xubo29@...>
Date:   2018-10-23T03:14:03Z

    [CARBONDATA-3032] Remove carbon.blocklet.size from properties template
   
    1.Remove carbon.blocklet.size from properties template, because carbon.blocklet.size is in V2, V3 use carbon.blockletgroup.size.in.mb or page size
    2.change numberComressor to numberCompressor
    3.optimize the annotation of method

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2842
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/942/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2842
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1148/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2842
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9206/



---

[qiuchenjian-2]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2842#discussion_r227356312
 
    --- Diff: docs/sdk-guide.md ---
    @@ -24,7 +24,8 @@ CarbonData provides SDK to facilitate
     
     # SDK Writer
     
    -In the carbon jars package, there exist a carbondata-store-sdk-x.x.x-SNAPSHOT.jar, including SDK writer and reader.
    +In the carbon jars package, there exist a carbondata-store-sdk-x.x.x-SNAPSHOT.jar, including SDK writer and reader.
    +If you want to use SDK, it needs other carbon jar or you can use carbondata-sdk.jar.
    --- End diff --
   
    What does this mean?
   
    User can
    1. only use SDK jar
    2. use other carbon jars instread (SDK jar not included?)
   
    Is my understanding correct?


---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2842
 
    For 'carbon.blocklet.size', why not remove this property in code now?


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2842#discussion_r227635359
 
    --- Diff: docs/sdk-guide.md ---
    @@ -24,7 +24,8 @@ CarbonData provides SDK to facilitate
     
     # SDK Writer
     
    -In the carbon jars package, there exist a carbondata-store-sdk-x.x.x-SNAPSHOT.jar, including SDK writer and reader.
    +In the carbon jars package, there exist a carbondata-store-sdk-x.x.x-SNAPSHOT.jar, including SDK writer and reader.
    +If you want to use SDK, it needs other carbon jar or you can use carbondata-sdk.jar.
    --- End diff --
   
     user use carbondata-store-sdk-x.x.x-SNAPSHOT.jar is not enough, it needs other carbon jar.
   
    but if user use carbondata-sdk.jar, it's enough



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2842
 
    @xuchuanyin not sure whether it will has new issue after remove 'carbon.blocklet.size'. and there are some test case to test carbon.data.file.version is V2 scenario


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2842
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1147/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2842
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9412/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2842
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1360/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2842#discussion_r229285157
 
    --- Diff: docs/sdk-guide.md ---
    @@ -24,7 +24,8 @@ CarbonData provides SDK to facilitate
     
     # SDK Writer
     
    -In the carbon jars package, there exist a carbondata-store-sdk-x.x.x-SNAPSHOT.jar, including SDK writer and reader.
    +In the carbon jars package, there exist a carbondata-store-sdk-x.x.x-SNAPSHOT.jar, including SDK writer and reader.
    +If you want to use SDK, it needs other carbon jar or you can use carbondata-sdk.jar.
    --- End diff --
   
    `it needs other carbon jar`
    This sentence is not very clear


---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2842
 
    @xuchuanyin @jackylk Please check this PR again


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2842#discussion_r229981151
 
    --- Diff: docs/sdk-guide.md ---
    @@ -24,7 +24,8 @@ CarbonData provides SDK to facilitate
     
     # SDK Writer
     
    -In the carbon jars package, there exist a carbondata-store-sdk-x.x.x-SNAPSHOT.jar, including SDK writer and reader.
    +In the carbon jars package, there exist a carbondata-store-sdk-x.x.x-SNAPSHOT.jar, including SDK writer and reader.
    +If you want to use SDK, it needs other carbon jar or you can use carbondata-sdk.jar.
    --- End diff --
   
    ok, I updated the doc, add all other jar


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2842
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1211/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2842
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1212/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2842
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9476/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2842
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1427/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/2842
 
    @jackylk I updated.please check


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2842
 
    LGTM


---