[GitHub] carbondata pull request #2860: [CARBONDATA-3046][Doc] Remove useless configu...

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2860: [CARBONDATA-3046][Doc] Remove useless configu...

qiuchenjian-2
GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2860

    [CARBONDATA-3046][Doc] Remove useless configurations in template properties

    some of the configurations is outdated, this PR removes them from the
    template properties file.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed?
     `NA`
     - [x] Any backward compatibility impacted?
      `NA`
     - [x] Document update required?
    `YES`
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
     `NA`
            - How it is tested? Please attach test report.
     `NA`
            - Is it a performance related change? Please attach the performance test report.
     `NA`
            - Any additional information to help reviewers in testing this change.
     `NA`
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
     `NA`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 181026_opt_property_template

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2860.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2860
   
----
commit d0c95badb109526aa04a7936dc5009c12375e532
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-10-26T08:51:59Z

    Remove useless configurations in template properties
   
    some of the configurations is outdated, this PR removes them from the
    template properties file.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2860: [CARBONDATA-3046][Doc] Remove useless configurations...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2860
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1039/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2860: [CARBONDATA-3046][Doc] Remove useless configurations...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2860
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9304/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2860: [CARBONDATA-3046][Doc] Remove useless configurations...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2860
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1252/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2860: [CARBONDATA-3046][Doc] Remove useless configurations...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2860
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2860: [CARBONDATA-3046][Doc] Remove useless configurations...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2860
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1044/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2860: [CARBONDATA-3046][Doc] Remove useless configurations...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2860
 
    Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1258/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2860: [CARBONDATA-3046][Doc] Remove useless configurations...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2860
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9310/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2860: [CARBONDATA-3046][Doc] Remove useless configurations...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2860
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2860: [CARBONDATA-3046][Doc] Remove useless configu...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2860


---