[GitHub] carbondata pull request #2872: [WIP] Added reusable buffer code

classic Classic list List threaded Threaded
76 messages Options
1234
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9472/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9515/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1466/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1251/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1264/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1479/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9528/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1387/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1597/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed  with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9645/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1388/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1389/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9647/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1599/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1392/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1602/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9650/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2872#discussion_r233321330
 
    --- Diff: integration/spark-datasource/src/main/spark2.1andspark2.2/org/apache/spark/sql/CarbonVectorProxy.java ---
    @@ -454,7 +458,11 @@ public ColumnVector reserveDictionaryIds(int capacity) {
          * and offset.
          */
         public void putAllByteArray(byte[] data, int offset, int length) {
    -      vector.arrayData().appendBytes(length, data, offset);
    +      try {
    +        byteArray.set(vector.arrayData(), data);
    --- End diff --
   
    please remove this



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2872
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1398/



---
1234